Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: tools/gn/setup.cc

Issue 2492273002: GN: Always check for bad items. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/setup.cc
diff --git a/tools/gn/setup.cc b/tools/gn/setup.cc
index c5eace2219f5df5f38f477d82159e7108309c381..8a433bcdbb1cacf67fd0e96bdbaf5f5bee9dc360 100644
--- a/tools/gn/setup.cc
+++ b/tools/gn/setup.cc
@@ -330,22 +330,20 @@ void Setup::RunPreMessageLoop() {
bool Setup::RunPostMessageLoop() {
Err err;
- if (build_settings_.check_for_bad_items()) {
- if (!builder_.CheckForBadItems(&err)) {
- err.PrintToStdout();
- return false;
- }
+ if (!builder_.CheckForBadItems(&err)) {
+ err.PrintToStdout();
+ return false;
+ }
- if (!build_settings_.build_args().VerifyAllOverridesUsed(&err)) {
- // TODO(brettw) implement a system to have a different marker for
- // warnings. Until we have a better system, print the error but don't
- // return failure unless requested on the command line.
- err.PrintToStdout();
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kFailOnUnusedArgs))
- return false;
- return true;
- }
+ if (!build_settings_.build_args().VerifyAllOverridesUsed(&err)) {
+ // TODO(brettw) implement a system to have a different marker for
+ // warnings. Until we have a better system, print the error but don't
+ // return failure unless requested on the command line.
+ err.PrintToStdout();
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kFailOnUnusedArgs))
+ return false;
+ return true;
}
if (check_public_headers_) {
« tools/gn/command_args.cc ('K') | « tools/gn/command_refs.cc ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698