Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: tools/gn/build_settings.h

Issue 2492273002: GN: Always check for bad items. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/build_settings.cc » ('j') | tools/gn/command_args.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/build_settings.h
diff --git a/tools/gn/build_settings.h b/tools/gn/build_settings.h
index 5424cf9523440faa55d66098fd9df6fda15e1c6e..0b986cd6aeab677c3aecd7078421199e55abba72 100644
--- a/tools/gn/build_settings.h
+++ b/tools/gn/build_settings.h
@@ -95,18 +95,6 @@ class BuildSettings {
exec_script_whitelist_ = std::move(list);
}
- // When set (the default), code should perform normal validation of inputs
- // and structures, like undefined or possibly incorrectly used things. For
- // some interrogation commands, we don't care about this and actually want
- // to allow the user to check the structure of the build to solve their
- // problem, and these checks are undesirable.
- bool check_for_bad_items() const {
- return check_for_bad_items_;
- }
- void set_check_for_bad_items(bool c) {
- check_for_bad_items_ = c;
- }
-
private:
base::FilePath root_path_;
std::string root_path_utf8_;
@@ -122,8 +110,6 @@ class BuildSettings {
std::unique_ptr<std::set<SourceFile>> exec_script_whitelist_;
- bool check_for_bad_items_;
-
BuildSettings& operator=(const BuildSettings& other); // Disallow.
};
« no previous file with comments | « no previous file | tools/gn/build_settings.cc » ('j') | tools/gn/command_args.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698