NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

BUG=660866
Committed: https://crrev.com/1a5f12f04de58d44e4198094e5f0bac36ce90517
Cr-Commit-Position: refs/heads/master@{#429961}

[Lei Zhang, 2016-11-04 02:18:09]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 02:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-04 02:19:49]

Description was changed from

==========
NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.
==========

to

==========
NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

BUG=660866
==========

[commit-bot: I haz the power, 2016-11-04 02:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:57:14]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-04 04:55:52]

thestig@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Lei Zhang, 2016-11-04 04:55:53]

I'll wait for https://codereview.chromium.org/2466693002/ to land first and then
fix the usage of InitializeForTest() there too.

[stevenjb, 2016-11-04 16:31:37]

https://codereview.chromium.org/2478573003/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2478573003/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:95: auto handler =
base::WrapUnique(new NetworkStateHandler());
My understanding is that MakeUnique<NetworkStateHandler>() is preferred here?

[Lei Zhang, 2016-11-04 18:30:37]

https://codereview.chromium.org/2478573003/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2478573003/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:95: auto handler =
base::WrapUnique(new NetworkStateHandler());
On 2016/11/04 16:31:37, stevenjb wrote:
> My understanding is that MakeUnique<NetworkStateHandler>() is preferred here?

First thing I tried, but the ctor is private.

[stevenjb, 2016-11-04 18:33:31]

lgtm

https://codereview.chromium.org/2478573003/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2478573003/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:95: auto handler =
base::WrapUnique(new NetworkStateHandler());
On 2016/11/04 18:30:37, Lei Zhang wrote:
> On 2016/11/04 16:31:37, stevenjb wrote:
> > My understanding is that MakeUnique<NetworkStateHandler>() is preferred
here?
> 
> First thing I tried, but the ctor is private.

Ah, right, I remember that part of the discussion now. OK, cheers.

[Lei Zhang, 2016-11-04 18:37:43]

On 2016/11/04 04:55:53, Lei Zhang wrote:
> I'll wait for https://codereview.chromium.org/2466693002/ to land first and
then
> fix the usage of InitializeForTest() there too.

Talked to kirtika - I will land first.

[Lei Zhang, 2016-11-04 18:38:23]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:39:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 18:46:37]

Description was changed from

==========
NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

BUG=660866
==========

to

==========
NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

BUG=660866
==========

[commit-bot: I haz the power, 2016-11-04 18:46:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 19:18:31]

Description was changed from

==========
NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

BUG=660866
==========

to

==========
NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

BUG=660866

Committed: https://crrev.com/1a5f12f04de58d44e4198094e5f0bac36ce90517
Cr-Commit-Position: refs/heads/master@{#429961}
==========

[commit-bot: I haz the power, 2016-11-04 19:18:32]

Patchset 1 (id:??) landed as
https://crrev.com/1a5f12f04de58d44e4198094e5f0bac36ce90517
Cr-Commit-Position: refs/heads/master@{#429961}