chromeos/network/network_connection_handler_unittest.cc - Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_connection_handler_unittest.cc

Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_connection_handler_unittest.cc

diff --git a/chromeos/network/network_connection_handler_unittest.cc b/chromeos/network/network_connection_handler_unittest.cc

index 729ec1eafcb62b0a5ae0d2f4a7042faeaeb21d92..0a00870fbc454e6f786e4a1e28a9a5a4f25444e2 100644

--- a/chromeos/network/network_connection_handler_unittest.cc

+++ b/chromeos/network/network_connection_handler_unittest.cc

@@ -134,7 +134,7 @@ class NetworkConnectionHandlerTest : public testing::Test {

base::RunLoop().RunUntilIdle();

LoginState::Initialize();

- network_state_handler_.reset(NetworkStateHandler::InitializeForTest());

+ network_state_handler_ = NetworkStateHandler::InitializeForTest();

network_config_handler_.reset(

NetworkConfigurationHandler::InitializeForTest(

network_state_handler_.get(),