chromeos/network/network_state_handler.h - Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state_handler.h

Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_state_handler.h

diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h

index b752227708f59086e83ce3f4bef30dc7d7ac2689..c3df34455630b05ede7cb0379c2c455d537c9597 100644

--- a/chromeos/network/network_state_handler.h

+++ b/chromeos/network/network_state_handler.h

@@ -244,7 +244,7 @@ class CHROMEOS_EXPORT NetworkStateHandler

const std::string& error);

// Constructs and initializes an instance for testing.

- static NetworkStateHandler* InitializeForTest();

+ static std::unique_ptr<NetworkStateHandler> InitializeForTest();

// Default set of comma separated interfaces on which to enable

// portal checking.