chromeos/network/client_cert_resolver_unittest.cc - Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/client_cert_resolver_unittest.cc

Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/client_cert_resolver_unittest.cc

diff --git a/chromeos/network/client_cert_resolver_unittest.cc b/chromeos/network/client_cert_resolver_unittest.cc

index 35c955190da2aa5b86a58d07deed705bfd9f8ee2..f64629dab784e55b8237a91d509a6eca127a13ff 100644

--- a/chromeos/network/client_cert_resolver_unittest.cc

+++ b/chromeos/network/client_cert_resolver_unittest.cc

@@ -135,7 +135,7 @@ class ClientCertResolverTest : public testing::Test,

}

void SetupNetworkHandlers() {

- network_state_handler_.reset(NetworkStateHandler::InitializeForTest());

+ network_state_handler_ = NetworkStateHandler::InitializeForTest();

network_profile_handler_.reset(new NetworkProfileHandler());

network_config_handler_.reset(new NetworkConfigurationHandler());

managed_config_handler_.reset(new ManagedNetworkConfigurationHandlerImpl());