Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chromeos/network/network_device_handler_unittest.cc

Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_device_handler_unittest.cc
diff --git a/chromeos/network/network_device_handler_unittest.cc b/chromeos/network/network_device_handler_unittest.cc
index 0d741f4a9eaa5944c5359148f8462bef051a01ab..5ce4e5ef20eb1cb6b1e8555bf450944a608508a7 100644
--- a/chromeos/network/network_device_handler_unittest.cc
+++ b/chromeos/network/network_device_handler_unittest.cc
@@ -50,7 +50,7 @@ class NetworkDeviceHandlerTest : public testing::Test {
error_callback_ = base::Bind(&NetworkDeviceHandlerTest::ErrorCallback,
base::Unretained(this));
- network_state_handler_.reset(NetworkStateHandler::InitializeForTest());
+ network_state_handler_ = NetworkStateHandler::InitializeForTest();
NetworkDeviceHandlerImpl* device_handler = new NetworkDeviceHandlerImpl;
device_handler->Init(network_state_handler_.get());
network_device_handler_.reset(device_handler);
@@ -183,7 +183,6 @@ TEST_F(NetworkDeviceHandlerTest, SetDeviceProperty) {
error_callback_);
base::RunLoop().RunUntilIdle();
EXPECT_NE(kResultSuccess, result_);
-
}
TEST_F(NetworkDeviceHandlerTest, CellularAllowRoaming) {

Powered by Google App Engine
This is Rietveld 408576698