Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: chromeos/network/network_connection_handler_unittest.cc

Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/network_connection_handler.h" 5 #include "chromeos/network/network_connection_handler.h"
6 6
7 #include <map> 7 #include <map>
8 #include <memory> 8 #include <memory>
9 #include <set> 9 #include <set>
10 10
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 "/device/wifi1", shill::kTypeWifi, "wifi_device1"); 127 "/device/wifi1", shill::kTypeWifi, "wifi_device1");
128 test_manager_client_->AddTechnology(shill::kTypeCellular, 128 test_manager_client_->AddTechnology(shill::kTypeCellular,
129 true /* enabled */); 129 true /* enabled */);
130 dbus_manager->GetShillProfileClient()->GetTestInterface()->AddProfile( 130 dbus_manager->GetShillProfileClient()->GetTestInterface()->AddProfile(
131 "shared_profile_path", std::string() /* shared profile */); 131 "shared_profile_path", std::string() /* shared profile */);
132 dbus_manager->GetShillProfileClient()->GetTestInterface()->AddProfile( 132 dbus_manager->GetShillProfileClient()->GetTestInterface()->AddProfile(
133 "user_profile_path", kUsernameHash); 133 "user_profile_path", kUsernameHash);
134 134
135 base::RunLoop().RunUntilIdle(); 135 base::RunLoop().RunUntilIdle();
136 LoginState::Initialize(); 136 LoginState::Initialize();
137 network_state_handler_.reset(NetworkStateHandler::InitializeForTest()); 137 network_state_handler_ = NetworkStateHandler::InitializeForTest();
138 network_config_handler_.reset( 138 network_config_handler_.reset(
139 NetworkConfigurationHandler::InitializeForTest( 139 NetworkConfigurationHandler::InitializeForTest(
140 network_state_handler_.get(), 140 network_state_handler_.get(),
141 nullptr /* network_device_handler */)); 141 nullptr /* network_device_handler */));
142 142
143 network_profile_handler_.reset(new NetworkProfileHandler()); 143 network_profile_handler_.reset(new NetworkProfileHandler());
144 network_profile_handler_->Init(); 144 network_profile_handler_->Init();
145 145
146 managed_config_handler_.reset(new ManagedNetworkConfigurationHandlerImpl()); 146 managed_config_handler_.reset(new ManagedNetworkConfigurationHandlerImpl());
147 managed_config_handler_->Init( 147 managed_config_handler_->Init(
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 Connect(kNoNetwork); 490 Connect(kNoNetwork);
491 EXPECT_EQ(NetworkConnectionHandler::kErrorConfigureFailed, 491 EXPECT_EQ(NetworkConnectionHandler::kErrorConfigureFailed,
492 GetResultAndReset()); 492 GetResultAndReset());
493 493
494 EXPECT_TRUE(Configure(kConfigConnectable)); 494 EXPECT_TRUE(Configure(kConfigConnectable));
495 Disconnect(kWifi0); 495 Disconnect(kWifi0);
496 EXPECT_EQ(NetworkConnectionHandler::kErrorNotConnected, GetResultAndReset()); 496 EXPECT_EQ(NetworkConnectionHandler::kErrorNotConnected, GetResultAndReset());
497 } 497 }
498 498
499 } // namespace chromeos 499 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698