Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: chromeos/network/auto_connect_handler_unittest.cc

Issue 2478573003: NetworkStateHandler::InitializeForTest() should return a std::unique_ptr. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/auto_connect_handler_unittest.cc
diff --git a/chromeos/network/auto_connect_handler_unittest.cc b/chromeos/network/auto_connect_handler_unittest.cc
index 846c302ea4a9e5dfef426ce99070e13c59a3cf23..acbcbcdeff77493834dc8614de0ab12ded392ffa 100644
--- a/chromeos/network/auto_connect_handler_unittest.cc
+++ b/chromeos/network/auto_connect_handler_unittest.cc
@@ -42,7 +42,7 @@ namespace chromeos {
namespace {
-const char* kUserHash = "user_hash";
+const char kUserHash[] = "user_hash";
void ConfigureCallback(const dbus::ObjectPath& result) {
}
@@ -110,7 +110,7 @@ class AutoConnectHandlerTest : public testing::Test {
base::RunLoop().RunUntilIdle();
LoginState::Initialize();
- network_state_handler_.reset(NetworkStateHandler::InitializeForTest());
+ network_state_handler_ = NetworkStateHandler::InitializeForTest();
network_config_handler_.reset(
NetworkConfigurationHandler::InitializeForTest(
network_state_handler_.get(), NULL /* network_device_handler */));
« no previous file with comments | « no previous file | chromeos/network/client_cert_resolver_unittest.cc » ('j') | chromeos/network/network_state_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698