Change call-sites now that SkCanvas is not ref-counted

Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=dtrainor@chromium.org

Committed: https://crrev.com/60c148ef13aed978fcaf5dae9e242f99618f2164
Cr-Commit-Position: refs/heads/master@{#432481}

[reed1, 2016-11-05 15:41:10]

Description was changed from

==========
change call-sites now that SkCanvas is not ref-counted

BUG=
==========

to

==========
change call-sites now that SkCanvas is not ref-counted

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[reed1, 2016-11-10 18:07:44]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 18:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-11-10 18:08:06]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:33:44]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[reed1, 2016-11-10 19:02:33]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:03:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 19:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 19:33:28]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[reed1, 2016-11-14 14:25:46]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 14:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 15:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 15:08:33]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[reed1, 2016-11-14 15:47:08]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 15:47:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 16:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:23:22]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[reed1, 2016-11-14 16:27:02]

Description was changed from

==========
change call-sites now that SkCanvas is not ref-counted

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[reed1, 2016-11-14 16:29:13]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 16:29:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-11-14 17:19:27]

reed@google.com changed reviewers:
+ ccameron@chromium.org, danakj@chromium.org, sky@chromium.org

[reed1, 2016-11-14 17:19:28]

need OWNERS

[Khushal, 2016-11-14 17:25:09]

On 2016/11/14 17:19:28, reed1 wrote:
> need OWNERS

blimp LGTM.

[f(malita), 2016-11-14 17:29:15]

lgtm

https://codereview.chromium.org/2476113002/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/2476113002/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_plugin_instance_impl.h:840: blink::WebCanvas*
canvas_;
This changes the ownership model.  Are we sure the canvas outlives this object? 
Maybe add some documentation?

[ccameron, 2016-11-14 17:44:18]

ui/, *mac*, content/browser/compositor lgtm

[commit-bot: I haz the power, 2016-11-14 19:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:16:36]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-11-14 19:35:15]

LGTM w/ a few comments

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
File cc/playback/display_item_list_unittest.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:57: canvas =
recorder.beginRecording(bounds.width(), bounds.height());
nit: move the var defn here too, so we don't have an uninit pointer ever

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:73: canvas =
recorder.beginRecording(SkRect::MakeXYWH(
same

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:90: canvas =
recorder.beginRecording(SkRect::MakeXYWH(
same

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:310: canvas =
recorder.beginRecording(gfx::RectFToSkRect(recording_rect));
same

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:351: canvas =
recorder.beginRecording(gfx::RectFToSkRect(first_recording_rect));
same

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:408: canvas =
recorder.beginRecording(gfx::RectFToSkRect(first_recording_rect));
same

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:488: canvas = recorder.beginRecording(
same

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:532: canvas =
recorder.beginRecording(gfx::RectFToSkRect(recording_rect));
same

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
File cc/test/fake_content_layer_client.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
cc/test/fake_content_layer_client.cc:67: canvas =
recorder.beginRecording(gfx::RectFToSkRect(draw_rect));
move the defn here so we don't have an uninit ptr and then a dangling ptr when
leaving scope

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
cc/test/fake_content_layer_client.cc:79: canvas =
recorder.beginRecording(it->image->width(), it->image->height());
also define another var here

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
cc/test/fake_content_layer_client.cc:95: canvas =
recorder.beginRecording(gfx::RectToSkRect(draw_rect));
and here

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.cc#newco...
ui/gfx/canvas.cc:49: canvas_ = canvas_owner_.get();
do this as a contructor init (you'll need to make it come after the
canvas_owner_ in the .h which is the right thing to do also)

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.h
File ui/gfx/canvas.h (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.h#newcode91
ui/gfx/canvas.h:91: // so no additional scaling is applied.
Can you mention that it must outlive the Canvas?

https://codereview.chromium.org/2476113002/diff/100001/ui/surface/transport_d...
File ui/surface/transport_dib_posix.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/surface/transport_d...
ui/surface/transport_dib_posix.cc:67: .release();
Please make GetPlatformCanvas return a unique_ptr instead. It's callers want
one.

[danakj, 2016-11-14 19:36:51]

One more

https://codereview.chromium.org/2476113002/diff/100001/ui/compositor/paint_re...
File ui/compositor/paint_recorder.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/compositor/paint_re...
ui/compositor/paint_recorder.cc:22: // the recorder_ so no need to store a
RefPtr to it on this class, we just
This comment is out of date now. Can you have it instead explain what is keeping
the SkCanvas passed to canvas_ alive for its lifetime?

[reed1, 2016-11-14 20:50:08]

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
File cc/playback/display_item_list_unittest.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:57: canvas =
recorder.beginRecording(bounds.width(), bounds.height());
On 2016/11/14 19:35:15, danakj wrote:
> nit: move the var defn here too, so we don't have an uninit pointer ever

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:73: canvas =
recorder.beginRecording(SkRect::MakeXYWH(
On 2016/11/14 19:35:15, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:90: canvas =
recorder.beginRecording(SkRect::MakeXYWH(
On 2016/11/14 19:35:14, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:310: canvas =
recorder.beginRecording(gfx::RectFToSkRect(recording_rect));
On 2016/11/14 19:35:14, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:351: canvas =
recorder.beginRecording(gfx::RectFToSkRect(first_recording_rect));
On 2016/11/14 19:35:15, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:408: canvas =
recorder.beginRecording(gfx::RectFToSkRect(first_recording_rect));
On 2016/11/14 19:35:14, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:488: canvas = recorder.beginRecording(
On 2016/11/14 19:35:15, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/playback/display_it...
cc/playback/display_item_list_unittest.cc:532: canvas =
recorder.beginRecording(gfx::RectFToSkRect(recording_rect));
On 2016/11/14 19:35:14, danakj wrote:
> same

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
File cc/test/fake_content_layer_client.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
cc/test/fake_content_layer_client.cc:67: canvas =
recorder.beginRecording(gfx::RectFToSkRect(draw_rect));
On 2016/11/14 19:35:15, danakj wrote:
> move the defn here so we don't have an uninit ptr and then a dangling ptr when
> leaving scope

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
cc/test/fake_content_layer_client.cc:79: canvas =
recorder.beginRecording(it->image->width(), it->image->height());
On 2016/11/14 19:35:15, danakj wrote:
> also define another var here

Done.

https://codereview.chromium.org/2476113002/diff/100001/cc/test/fake_content_l...
cc/test/fake_content_layer_client.cc:95: canvas =
recorder.beginRecording(gfx::RectToSkRect(draw_rect));
On 2016/11/14 19:35:15, danakj wrote:
> and here

Done.

https://codereview.chromium.org/2476113002/diff/100001/content/renderer/peppe...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/2476113002/diff/100001/content/renderer/peppe...
content/renderer/pepper/pepper_plugin_instance_impl.h:840: blink::WebCanvas*
canvas_;
On 2016/11/14 17:29:15, f(malita) wrote:
> This changes the ownership model.  Are we sure the canvas outlives this
object? 
> Maybe add some documentation?

Done.

https://codereview.chromium.org/2476113002/diff/100001/ui/compositor/paint_re...
File ui/compositor/paint_recorder.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/compositor/paint_re...
ui/compositor/paint_recorder.cc:22: // the recorder_ so no need to store a
RefPtr to it on this class, we just
On 2016/11/14 19:36:51, danakj wrote:
> This comment is out of date now. Can you have it instead explain what is
keeping
> the SkCanvas passed to canvas_ alive for its lifetime?

Done.

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.cc#newco...
ui/gfx/canvas.cc:49: canvas_ = canvas_owner_.get();
On 2016/11/14 19:35:15, danakj wrote:
> do this as a contructor init (you'll need to make it come after the
> canvas_owner_ in the .h which is the right thing to do also)

Done.

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.h
File ui/gfx/canvas.h (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/gfx/canvas.h#newcode91
ui/gfx/canvas.h:91: // so no additional scaling is applied.
On 2016/11/14 19:35:15, danakj wrote:
> Can you mention that it must outlive the Canvas?

Done.

https://codereview.chromium.org/2476113002/diff/100001/ui/surface/transport_d...
File ui/surface/transport_dib_posix.cc (right):

https://codereview.chromium.org/2476113002/diff/100001/ui/surface/transport_d...
ui/surface/transport_dib_posix.cc:67: .release();
On 2016/11/14 19:35:15, danakj wrote:
> Please make GetPlatformCanvas return a unique_ptr instead. It's callers want
> one.

Done.

[reed1, 2016-11-14 20:50:26]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 20:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-11-14 20:59:56]

Thanks! LGTM w/ a followup on the comment change

https://codereview.chromium.org/2476113002/diff/120001/ui/compositor/paint_re...
File ui/compositor/paint_recorder.cc (right):

https://codereview.chromium.org/2476113002/diff/120001/ui/compositor/paint_re...
ui/compositor/paint_recorder.cc:22: // recorder_
fix wrapping please

https://codereview.chromium.org/2476113002/diff/120001/ui/compositor/paint_re...
ui/compositor/paint_recorder.cc:23: // so no need to store a RefPtr to it on
this class, we just store the
Hm this is still referring to RefPtr.

How about something like:

The |context| must outlive this class which causes the |recorder_| to also
outlive this class, so the |canvas_| will be valid for the lifetime of this
class.

[reed1, 2016-11-14 21:28:51]

https://codereview.chromium.org/2476113002/diff/120001/ui/compositor/paint_re...
File ui/compositor/paint_recorder.cc (right):

https://codereview.chromium.org/2476113002/diff/120001/ui/compositor/paint_re...
ui/compositor/paint_recorder.cc:22: // recorder_
On 2016/11/14 20:59:56, danakj wrote:
> fix wrapping please

Done.

https://codereview.chromium.org/2476113002/diff/120001/ui/compositor/paint_re...
ui/compositor/paint_recorder.cc:23: // so no need to store a RefPtr to it on
this class, we just store the
On 2016/11/14 20:59:56, danakj wrote:
> Hm this is still referring to RefPtr.
> 
> How about something like:
> 
> The |context| must outlive this class which causes the |recorder_| to also
> outlive this class, so the |canvas_| will be valid for the lifetime of this
> class.

New comment uploaded, that also references cache, (for which we also need a
valid reference during our lifetime).

[reed1, 2016-11-14 21:29:48]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 21:31:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 22:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:18:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[reed1, 2016-11-15 15:39:27]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 15:39:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 16:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 16:21:47]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[reed1, 2016-11-15 16:43:15]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 16:43:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-11-15 16:55:39]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-11-15 16:55:51]

The CQ bit was checked by reed@google.com

[reed1, 2016-11-15 16:55:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, fmalita@chromium.org, khushalsagar@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2476113002/#ps180001
(title: "try fixing win again")

[commit-bot: I haz the power, 2016-11-15 16:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 17:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 17:15:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reed1, 2016-11-15 18:42:48]

reed@google.com changed reviewers:
+ blundell@chromium.org, esprehn@chromium.org, raymes@chromium.org,
tobiasjs@chromium.org

[reed1, 2016-11-15 18:42:49]

need more OWNERS

    android_webview/native/
    chrome/browser/android/compositor/layer/
    components/test_runner/
    content/renderer/pepper/
    ppapi/proxy/

[raymes, 2016-11-15 21:40:49]

ppapi lgtm

[esprehn, 2016-11-15 22:20:28]

Description was changed from

==========
change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[esprehn, 2016-11-15 22:20:28]

esprehn@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[esprehn, 2016-11-15 22:22:22]

https://codereview.chromium.org/2476113002/diff/180001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_pixeltest_masks.cc (right):

https://codereview.chromium.org/2476113002/diff/180001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_pixeltest_masks.cc:43: SkCanvas* canvas =
What frees the canvas now?

[Tobias Sargeant, 2016-11-15 22:52:48]

android_webview/ LGTM

[reed1, 2016-11-16 03:51:21]

https://codereview.chromium.org/2476113002/diff/180001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_pixeltest_masks.cc (right):

https://codereview.chromium.org/2476113002/diff/180001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_pixeltest_masks.cc:43: SkCanvas* canvas =
On 2016/11/15 22:22:21, esprehn wrote:
> What frees the canvas now?

The recorder itself maintains ownership of the canvas. That's why beginRecording
returns SkCanvas* instead of either sk_sp<> or unique_ptr<>.

[esprehn, 2016-11-16 04:07:46]

lgtm

[blundell, 2016-11-16 10:15:27]

//components/test_runner lgtm

[reed1, 2016-11-16 13:47:56]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-11-16 13:48:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 13:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 13:59:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reed1, 2016-11-16 14:35:53]

Description was changed from

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=dtrainor@chromium.org
==========

[reed1, 2016-11-16 14:36:01]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-11-16 14:36:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 14:47:14]

Description was changed from

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=dtrainor@chromium.org
==========

to

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=dtrainor@chromium.org
==========

[commit-bot: I haz the power, 2016-11-16 14:47:16]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-11-16 14:49:26]

Description was changed from

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=dtrainor@chromium.org
==========

to

==========
Change call-sites now that SkCanvas is not ref-counted

BUG=skia:5971
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=dtrainor@chromium.org

Committed: https://crrev.com/60c148ef13aed978fcaf5dae9e242f99618f2164
Cr-Commit-Position: refs/heads/master@{#432481}
==========

[commit-bot: I haz the power, 2016-11-16 14:49:28]

Patchset 10 (id:??) landed as
https://crrev.com/60c148ef13aed978fcaf5dae9e242f99618f2164
Cr-Commit-Position: refs/heads/master@{#432481}

[reed1, 2016-11-17 14:47:57]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2515433002/ by reed@google.com.

The reason for reverting is: Believe this caused a crash 

https://bugs.chromium.org/p/chromium/issues/detail?id=666154.