Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Unified Diff: android_webview/native/java_browser_view_renderer_helper.cc

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)
Patch Set: try fixing win again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/java_browser_view_renderer_helper.cc
diff --git a/android_webview/native/java_browser_view_renderer_helper.cc b/android_webview/native/java_browser_view_renderer_helper.cc
index 8d8ee8da76627d90270529ad5d81cb3d21171b01..70eca1dd22769978df0d1dd97d84864ae818c152 100644
--- a/android_webview/native/java_browser_view_renderer_helper.cc
+++ b/android_webview/native/java_browser_view_renderer_helper.cc
@@ -8,6 +8,7 @@
#include "android_webview/public/browser/draw_sw.h"
#include "base/android/scoped_java_ref.h"
+#include "base/memory/ptr_util.h"
#include "base/trace_event/trace_event.h"
#include "jni/JavaBrowserViewRendererHelper_jni.h"
#include "third_party/skia/include/core/SkBitmap.h"
@@ -35,7 +36,7 @@ class JavaCanvasHolder : public SoftwareCanvasHolder {
private:
AwPixelInfo* pixels_;
- sk_sp<SkCanvas> canvas_;
+ std::unique_ptr<SkCanvas> canvas_;
DISALLOW_COPY_AND_ASSIGN(JavaCanvasHolder);
};
@@ -49,8 +50,7 @@ JavaCanvasHolder::JavaCanvasHolder(JNIEnv* env,
if (!pixels_ || !pixels_->state)
return;
- canvas_ = sk_sp<SkCanvas>(
- SkCanvasStateUtils::CreateFromCanvasState(pixels_->state));
+ canvas_ = SkCanvasStateUtils::MakeFromCanvasState(pixels_->state);
// Workarounds for http://crbug.com/271096: SW draw only supports
// translate & scale transforms, and a simple rectangular clip.
if (canvas_ && (!canvas_->isClipRect() ||
@@ -88,7 +88,7 @@ class AuxiliaryCanvasHolder : public SoftwareCanvasHolder {
ScopedJavaLocalRef<jobject> jbitmap_;
gfx::Vector2d scroll_;
std::unique_ptr<SkBitmap> bitmap_;
- sk_sp<SkCanvas> canvas_;
+ std::unique_ptr<SkCanvas> canvas_;
DISALLOW_COPY_AND_ASSIGN(AuxiliaryCanvasHolder);
};
@@ -121,7 +121,7 @@ AuxiliaryCanvasHolder::AuxiliaryCanvasHolder(
SkImageInfo::MakeN32Premul(bitmap_info.width, bitmap_info.height);
bitmap_.reset(new SkBitmap);
bitmap_->installPixels(info, pixels, bitmap_info.stride);
- canvas_ = sk_make_sp<SkCanvas>(*bitmap_);
+ canvas_ = base::MakeUnique<SkCanvas>(*bitmap_);
}
AuxiliaryCanvasHolder::~AuxiliaryCanvasHolder() {

Powered by Google App Engine
This is Rietveld 408576698