Change call-sites now that SkCanvas is not ref-counted

ui/compositor/paint_recorder.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/paint_recorder.h"
 
 #include "cc/playback/display_item_list.h"
 #include "cc/playback/drawing_display_item.h"
 #include "third_party/skia/include/core/SkPictureRecorder.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
 #include "ui/compositor/paint_cache.h"
 #include "ui/compositor/paint_context.h"
 #include "ui/gfx/skia_util.h"
 
 namespace ui {
 
 PaintRecorder::PaintRecorder(const PaintContext& context,
                              const gfx::Size& recording_size,
                              PaintCache* cache)
     : context_(context),
-      // The SkCanvas reference returned by beginRecording is shared with
-      // the recorder_ so no need to store a RefPtr to it on this class, we just
-      // store the gfx::Canvas.
-      canvas_(sk_ref_sp(context.recorder_->beginRecording(
-                        gfx::RectToSkRect(gfx::Rect(recording_size)))),
+      // The SkCanvas pointer returned by beginRecording is owned by the
+      // recorder_

[danakj, 2016/11/14 20:59:56]

fix wrapping please

[reed1, 2016/11/14 21:28:51]

Done.

+      // so no need to store a RefPtr to it on this class, we just store the

[danakj, 2016/11/14 20:59:56]

Hm this is still referring to RefPtr.

How about something like:

The |context| must outlive this class which causes the |recorder_| to also
outlive this class, so the |canvas_| will be valid for the lifetime of this
class.

[reed1, 2016/11/14 21:28:51]

New comment uploaded, that also references cache, (for which we also need a
valid reference during our lifetime).

+      // gfx::Canvas.
+      // The caller must ensure that the PaintContext's recorder_ outlives this
+      // object.
+      canvas_(context.recorder_->beginRecording(
+                  gfx::RectToSkRect(gfx::Rect(recording_size))),
               context.device_scale_factor_),
       cache_(cache),
       bounds_in_layer_(context.ToLayerSpaceBounds(recording_size)) {
 #if DCHECK_IS_ON()
   DCHECK(!context.inside_paint_recorder_);
   context.inside_paint_recorder_ = true;
 #endif
 }
 
 PaintRecorder::PaintRecorder(const PaintContext& context,
                              const gfx::Size& recording_size)
     : PaintRecorder(context, recording_size, nullptr) {
 }
 
 PaintRecorder::~PaintRecorder() {
 #if DCHECK_IS_ON()
   context_.inside_paint_recorder_ = false;
 #endif
   const auto& item =
       context_.list_->CreateAndAppendDrawingItem<cc::DrawingDisplayItem>(
           bounds_in_layer_, context_.recorder_->finishRecordingAsPicture());
   if (cache_)
     cache_->SetCache(item);
 }
 
 }  // namespace ui