Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2515433002: Revert of Change call-sites now that SkCanvas is not ref-counted (Closed)

Created:
4 years, 1 month ago by reed1
Modified:
4 years, 1 month ago
CC:
anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, cc-bugs_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change call-sites now that SkCanvas is not ref-counted (patchset #10 id:180001 of https://codereview.chromium.org/2476113002/ ) Reason for revert: Believe this caused a crash https://bugs.chromium.org/p/chromium/issues/detail?id=666154 Original issue's description: > Change call-sites now that SkCanvas is not ref-counted > > BUG=skia:5971 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > TBR=dtrainor@chromium.org > > Committed: https://crrev.com/60c148ef13aed978fcaf5dae9e242f99618f2164 > Cr-Commit-Position: refs/heads/master@{#432481} TBR=esprehn@chromium.org,blundell@chromium.org,ccameron@chromium.org,danakj@chromium.org,fmalita@chromium.org,khushalsagar@chromium.org,raymes@chromium.org,sky@chromium.org,tobiasjs@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -210 lines) Patch
M android_webview/native/java_browser_view_renderer_helper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M blimp/test/support/compositor/picture_cache_test_support.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/blimp/compositor_state_deserializer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/blimp/picture_data_conversions_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/output/software_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/discardable_image_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/discardable_image_map.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 14 chunks +28 lines, -17 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/test/solid_color_content_layer_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/layer/crushed_sprite_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/crushed_sprite_layer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/test_runner/pixel_dump.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +40 lines, -44 lines 0 comments Download
M skia/ext/platform_canvas.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/paint_recorder.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/canvas.h View 3 chunks +3 lines, -10 lines 0 comments Download
M ui/gfx/canvas.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/surface/transport_dib.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/surface/transport_dib_posix.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/surface/transport_dib_win.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/border_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
reed1
Created Revert of Change call-sites now that SkCanvas is not ref-counted
4 years, 1 month ago (2016-11-17 14:47:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515433002/1
4 years, 1 month ago (2016-11-17 14:48:12 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 14:50:39 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698