Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: components/test_runner/pixel_dump.cc

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)
Patch Set: try fixing win again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/pixel_dump.cc
diff --git a/components/test_runner/pixel_dump.cc b/components/test_runner/pixel_dump.cc
index de2316a71aa982164597c787bd2b515cba6568b2..67881c94b30008ab4e48d40cc36e9bd873e868de 100644
--- a/components/test_runner/pixel_dump.cc
+++ b/components/test_runner/pixel_dump.cc
@@ -96,8 +96,8 @@ void CapturePixelsForPrinting(std::unique_ptr<PixelsDumpRequest> dump_request) {
int totalHeight = page_count * (page_size_in_pixels.height + 1) - 1;
bool is_opaque = false;
- sk_sp<SkCanvas> canvas(skia::TryCreateBitmapCanvas(
- page_size_in_pixels.width, totalHeight, is_opaque));
+ std::unique_ptr<SkCanvas> canvas = skia::TryCreateBitmapCanvas(
+ page_size_in_pixels.width, totalHeight, is_opaque);
if (!canvas) {
LOG(ERROR) << "Failed to create canvas width="
<< page_size_in_pixels.width << " height=" << totalHeight;

Powered by Google App Engine
This is Rietveld 408576698