Change call-sites now that SkCanvas is not ref-counted

cc/test/fake_content_layer_client.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/fake_content_layer_client.h"
 
 #include <stddef.h>
 
 #include "cc/playback/clip_display_item.h"
 #include "cc/playback/display_item_list_settings.h"
@@ skipping 40 matching lines @@
 FakeContentLayerClient::PaintContentsToDisplayList(
     PaintingControlSetting painting_control) {
   // Cached picture is used because unit tests expect to be able to
   // use GatherPixelRefs.
   DisplayItemListSettings settings;
   settings.use_cached_picture = display_list_use_cached_picture_;
   scoped_refptr<DisplayItemList> display_list =
       DisplayItemList::Create(settings);
   display_list->SetRetainVisualRectsForTesting(true);
   SkPictureRecorder recorder;
-  sk_sp<SkCanvas> canvas;
+  SkCanvas* canvas;
 
   for (RectPaintVector::const_iterator it = draw_rects_.begin();
        it != draw_rects_.end(); ++it) {
     const gfx::RectF& draw_rect = it->first;
     const SkPaint& paint = it->second;
-    canvas = sk_ref_sp(recorder.beginRecording(gfx::RectFToSkRect(draw_rect)));
+    canvas = recorder.beginRecording(gfx::RectFToSkRect(draw_rect));

[danakj, 2016/11/14 19:35:15]

move the defn here so we don't have an uninit ptr and then a dangling ptr when
leaving scope

[reed1, 2016/11/14 20:50:08]

Done.

     canvas->drawRect(gfx::RectFToSkRect(draw_rect), paint);
     display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
         ToEnclosingRect(draw_rect), recorder.finishRecordingAsPicture());
   }
 
   for (ImageVector::const_iterator it = draw_images_.begin();
        it != draw_images_.end(); ++it) {
     if (!it->transform.IsIdentity()) {
       display_list->CreateAndAppendPairedBeginItem<TransformDisplayItem>(
           it->transform);
     }
-    canvas = sk_ref_sp(
-        recorder.beginRecording(it->image->width(), it->image->height()));
+    canvas = recorder.beginRecording(it->image->width(), it->image->height());

[danakj, 2016/11/14 19:35:15]

also define another var here

[reed1, 2016/11/14 20:50:08]

Done.

     canvas->drawImage(it->image.get(), it->point.x(), it->point.y(),
                       &it->paint);
     display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
         PaintableRegion(), recorder.finishRecordingAsPicture());
     if (!it->transform.IsIdentity()) {
       display_list->CreateAndAppendPairedEndItem<EndTransformDisplayItem>();
     }
   }
 
   if (fill_with_nonsolid_color_) {
     gfx::Rect draw_rect = PaintableRegion();
     bool red = true;
     while (!draw_rect.IsEmpty()) {
       SkPaint paint;
       paint.setColor(red ? SK_ColorRED : SK_ColorBLUE);
-      canvas = sk_ref_sp(recorder.beginRecording(gfx::RectToSkRect(draw_rect)));
+      canvas = recorder.beginRecording(gfx::RectToSkRect(draw_rect));

[danakj, 2016/11/14 19:35:15]

and here

[reed1, 2016/11/14 20:50:08]

Done.

       canvas->drawIRect(gfx::RectToSkIRect(draw_rect), paint);
       display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
           draw_rect, recorder.finishRecordingAsPicture());
       draw_rect.Inset(1, 1);
     }
   }
 
   display_list->Finalize();
   return display_list;
 }
 
 bool FakeContentLayerClient::FillsBoundsCompletely() const { return false; }
 
 size_t FakeContentLayerClient::GetApproximateUnsharedMemoryUsage() const {
   return reported_memory_usage_;
 }
 
 }  // namespace cc