Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2612)

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 2476113002: Change call-sites now that SkCanvas is not ref-counted (Closed)
Patch Set: try fixing win again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_plugin_instance_impl.h
diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h
index cac1a756e4ee03bf98efa6cf5c860e1713df6490..37da8a1477c7ca8bed6073effa39fb7e13bf28c5 100644
--- a/content/renderer/pepper/pepper_plugin_instance_impl.h
+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h
@@ -836,8 +836,9 @@ class CONTENT_EXPORT PepperPluginInstanceImpl
// is preserved in PrintWebViewHelper::PrintPages. This makes it possible
// to generate the entire PDF given the variables below:
//
- // The most recently used WebCanvas, guaranteed to be valid.
- sk_sp<blink::WebCanvas> canvas_;
+ // The most recently used WebCanvas to be used in printEnd(). Caller must
+ // ensure that it remains valid until that point.
+ blink::WebCanvas* canvas_;
// An array of page ranges.
std::vector<PP_PrintPageNumberRange_Dev> ranges_;

Powered by Google App Engine
This is Rietveld 408576698