Make EfficientLength extend Iterable.

Make EfficientLength extend Iterable.

This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/b08fb1373f88121bb4056adce9b71849a5bede2a
Committed: https://github.com/dart-lang/sdk/commit/7957a1c2562ae4398ac05e5b36b3df06fff423a9

[Lasse Reichstein Nielsen, 2016-11-02 12:35:10]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-11-02 12:38:20]

LGTM.

[Lasse Reichstein Nielsen, 2016-11-02 13:02:45]

https://codereview.chromium.org/2467113003/diff/20001/runtime/vm/debugger_api...
File runtime/vm/debugger_api_impl_test.cc (right):

https://codereview.chromium.org/2467113003/diff/20001/runtime/vm/debugger_api...
runtime/vm/debugger_api_impl_test.cc:2263: const Type& actual_type =
Api::UnwrapTypeHandle(zone, super2_type);
This is a *minimal* fix for this test.

Preferably it should not assume that the platform libraries are stable, and
should be run on sample code that it is in control of.
(The test failing here doesn't mean that there is a bug in the changes, just
that the test made an assumption that no longer holds - the bug is in the test).

[Lasse Reichstein Nielsen, 2016-11-02 13:05:38]

Description was changed from

==========
Make EfficientLength extend Iterable.

This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.
==========

to

==========
Make EfficientLength extend Iterable.

This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b08fb1373f88121bb4056adce9b71849a5bede2a
==========

[Lasse Reichstein Nielsen, 2016-11-02 13:05:40]

Committed patchset #2 (id:20001) manually as
b08fb1373f88121bb4056adce9b71849a5bede2a (presubmit successful).

[Lasse Reichstein Nielsen, 2016-11-02 13:11:27]

@vsm, @sigmund
I did not change the DDC libraries in this change.
I had the changes to the Dart files, but couldn't find an easy way to fix the js
files that also refer to EfficientLength.

[vsm, 2016-11-02 20:11:24]

On 2016/11/02 13:11:27, Lasse Reichstein Nielsen wrote:
> @vsm, @sigmund
> I did not change the DDC libraries in this change.
> I had the changes to the Dart files, but couldn't find an easy way to fix the
js
> files that also refer to EfficientLength.

You just need to run ./tool/presubmit.sh from pkg/dev_compiler.  Do you have the
same changes for DDC in a cl?  If you hit any issues, I can run that for you.

[siva, 2016-11-02 20:21:58]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-11-02 20:21:58]

This appears to have broken the analyzer as used by Flutter
see (https://travis-ci.org/flutter/flutter/builds/172706676).

The new test is also failing on Dartium.

The cl has been reverted for now.

[siva, 2016-11-02 20:37:30]

I think the flutter issue could have been because they
rolled the VM independent of the SDK and in this case
we have changes both in the corelib and corresponding
changes in patch files under the VM directory.

You should be able to land this once we sort this out with
the flutter folks.

I don't know why the test is failing under dartium though.

[Lasse Reichstein Nielsen, 2016-11-28 07:04:30]

Description was changed from

==========
Make EfficientLength extend Iterable.

This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b08fb1373f88121bb4056adce9b71849a5bede2a
==========

to

==========
Make EfficientLength extend Iterable.

This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b08fb1373f88121bb4056adce9b71849a5bede2a
Committed:
https://github.com/dart-lang/sdk/commit/7957a1c2562ae4398ac05e5b36b3df06fff423a9
==========

[Lasse Reichstein Nielsen, 2016-11-28 07:04:34]

Committed patchset #3 (id:40001) manually as
7957a1c2562ae4398ac05e5b36b3df06fff423a9 (presubmit successful).