runtime/lib/growable_array.dart - Issue 2467113003: Make EfficientLength extend Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/growable_array.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)

Patch Set: Reverted, prepare to reland. Make new test not break web-testing framework. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/growable_array.dart

diff --git a/runtime/lib/growable_array.dart b/runtime/lib/growable_array.dart

index 9e942e4c5fc112a08194f5667345a3faf1456fd6..d35c1c44f096ea8043fcbcd76c0e517fdd373690 100644

--- a/runtime/lib/growable_array.dart

+++ b/runtime/lib/growable_array.dart

@@ -174,7 +174,7 @@ class _GrowableList<T> extends ListBase<T> {

(cid == ClassID.cidArray) ||

(cid == ClassID.cidGrowableObjectArray) ||

(cid == ClassID.cidImmutableArray);

- if (isVMList || (iterable is EfficientLength)) {

+ if (isVMList || (iterable is EfficientLengthIterable)) {

var cap = _capacity;

// Pregrow if we know iterable.length.

var iterLen = iterable.length;

« no previous file with comments | « runtime/lib/collection_patch.dart ('k') | runtime/lib/immutable_map.dart » ('j') | no next file with comments »