sdk/lib/collection/iterable.dart - Issue 2467113003: Make EfficientLength extend Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/collection/iterable.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)

Patch Set: Reverted, prepare to reland. Make new test not break web-testing framework. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/collection/iterable.dart

diff --git a/sdk/lib/collection/iterable.dart b/sdk/lib/collection/iterable.dart

index 26ccb5ca3b9d776535c06574c57589a8e8b18d72..edfce8515bdf2b7b37125dc8f5e48706c3fa4652 100644

--- a/sdk/lib/collection/iterable.dart

+++ b/sdk/lib/collection/iterable.dart

@@ -91,7 +91,7 @@ abstract class IterableMixin<E> implements Iterable<E> {

Set<E> toSet() => new Set<E>.from(this);

int get length {

- assert(this is! EfficientLength);

+ assert(this is! EfficientLengthIterable);

int count = 0;

Iterator it = iterator;

while (it.moveNext()) {

« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/linked_hash_map.dart ('k') | sdk/lib/collection/list.dart » ('j') | no next file with comments »