sdk/lib/collection/maps.dart - Issue 2467113003: Make EfficientLength extend Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/collection/maps.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)

Patch Set: Reverted, prepare to reland. Make new test not break web-testing framework. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/collection/maps.dart

diff --git a/sdk/lib/collection/maps.dart b/sdk/lib/collection/maps.dart

index 7871b8720b1351190766c03865d7defec267e7c3..d5b86210ad1fa8610fce6da2f5cfcbc6e84ed22a 100644

--- a/sdk/lib/collection/maps.dart

+++ b/sdk/lib/collection/maps.dart

@@ -111,8 +111,7 @@ abstract class UnmodifiableMapBase<K, V> =

* It accesses the values by iterating over the keys of the map, and using the

* map's `operator[]` to lookup the keys.

-class _MapBaseValueIterable<K, V> extends Iterable<V>

- implements EfficientLength {

+class _MapBaseValueIterable<K, V> extends EfficientLengthIterable<V> {

final Map<K, V> _map;

_MapBaseValueIterable(this._map);

« no previous file with comments | « sdk/lib/collection/list.dart ('k') | sdk/lib/collection/queue.dart » ('j') | no next file with comments »