runtime/lib/string_patch.dart - Issue 2467113003: Make EfficientLength extend Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string_patch.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)

Patch Set: Reverted, prepare to reland. Make new test not break web-testing framework. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/string_patch.dart

diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart

index 5abad6613e3e5064855f0a230fb915d404d87223..f046d8fd4e1c6c998c102cd62983b0d905bccde6 100644

--- a/runtime/lib/string_patch.dart

+++ b/runtime/lib/string_patch.dart

@@ -155,7 +155,7 @@ abstract class _StringBase {

static String _createStringFromIterable(Iterable<int> charCodes,

int start, int end) {

// Treat charCodes as Iterable.

- if (charCodes is EfficientLength) {

+ if (charCodes is EfficientLengthIterable) {

int length = charCodes.length;

end = RangeError.checkValidRange(start, end, length);

List charCodeList = new List.from(charCodes.take(end).skip(start),

« no previous file with comments | « runtime/lib/immutable_map.dart ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »