runtime/vm/debugger_api_impl_test.cc - Issue 2467113003: Make EfficientLength extend Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)

Patch Set: Reverted, prepare to reland. Make new test not break web-testing framework. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger_api_impl_test.cc

diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc

index a41d10b2081cddb14b45942af89f163eaf66d000..37dca4b1f21a0c90b25980cd3cb79390666a81e8 100644

--- a/runtime/vm/debugger_api_impl_test.cc

+++ b/runtime/vm/debugger_api_impl_test.cc

@@ -2257,9 +2257,10 @@ TEST_CASE(Debug_GetSupertype) {

{

Dart_Handle set_type = Dart_GetType(core_lib, set_name, 0, NULL);

Dart_Handle super_type = Dart_GetSupertype(set_type);

+ Dart_Handle super2_type = Dart_GetSupertype(super_type);

Dart_Handle iterable_type = Dart_GetType(core_lib, iterable_name, 0, NULL);

const Type& expected_type = Api::UnwrapTypeHandle(zone, iterable_type);

- const Type& actual_type = Api::UnwrapTypeHandle(zone, super_type);

+ const Type& actual_type = Api::UnwrapTypeHandle(zone, super2_type);

EXPECT(expected_type.raw() == actual_type.raw());

}

{