runtime/lib/array_patch.dart - Issue 2467113003: Make EfficientLength extend Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/array_patch.dart

Issue 2467113003: Make EfficientLength extend Iterable. (Closed)

Patch Set: Reverted, prepare to reland. Make new test not break web-testing framework. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/array_patch.dart

diff --git a/runtime/lib/array_patch.dart b/runtime/lib/array_patch.dart

index e62524bd124ddd79fcfd779bc7d7705b34878322..f8343941905d1ddb2c5d28e186722763f1c4d648 100644

--- a/runtime/lib/array_patch.dart

+++ b/runtime/lib/array_patch.dart

@@ -33,7 +33,7 @@ const _GROWABLE_ARRAY_MARKER = const _GrowableArrayMarker();

}

@patch factory List.from(Iterable elements, { bool growable: true }) {

- if (elements is EfficientLength) {

+ if (elements is EfficientLengthIterable) {

int length = elements.length;

var list = growable ? new _GrowableList<E>(length) : new _List<E>(length);

if (length > 0) { // Avoid creating iterator unless necessary.

« no previous file with comments | « no previous file | runtime/lib/collection_patch.dart » ('j') | no next file with comments »