Use m_GlyphIndex as backup for m_ExtGID on Mac

M55: Use m_GlyphIndex as backup for m_ExtGID on Mac

When CGFontGetGlyphWithGlyphName returns 0, it means the glyph name
was not recognized. In this case, try using the glyph index to load the
glyph.

BUG=pdfium:625
Review-Url: https://codereview.chromium.org/2445933002
(cherry picked from commit 4ee6139e8cfecab9e181115894b26131ad6de09a)

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e3183750107b0d54a0229874b1da75e2cae8c3ea

[npm, 2016-10-28 18:45:45]

Patchset #1 (id:1) has been deleted

[npm, 2016-10-28 18:46:15]

Description was changed from

==========
Use m_GlyphIndex as backup for m_ExtGID on Mac

When CGFontGetGlyphWithGlyphName returns 0, it means the glyph name
was not recognized. In this case, try using the glyph index to load the
glyph.

BUG=pdfium:625

Review-Url: https://codereview.chromium.org/2445933002
(cherry picked from commit 4ee6139e8cfecab9e181115894b26131ad6de09a)

M55: Convert from int to float values.

The CPDF_Page::GetDisplayMatrix expects to set float values into the
|display_matrix| but all of the input values are currently int. It is possible
to overflow the int values, so this CL changes the variables to be int which
closer reflects what they're being used for.

BUG=chromium:652038

Review-Url: https://codereview.chromium.org/2412983002
(cherry picked from commit 798e18f5e5cfb672c7f3186f6358b84c5ff7785b)

Review URL: https://codereview.chromium.org/2456943002 .

M55: Fixup formfiller cleanup

The CFFL_InteractiveFormFiller must be cleaned up before the environment because
the destruction of the formfiller will trigger the destruction of the formfiller
widgets. Some of those widgets may require stopping timers, which requires
accessing the environment.

BUG=chromium:654272, chromium:653459
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2408163003
(cherry picked from commit 709f5a9301e91365ab87610993c497e386504ead)

Review URL: https://codereview.chromium.org/2445873002 .

M55: Strengthen bounds check in CWeightTable::Calc * part II

This CL implemented a better version of CWeightTable::GetPixelWeightSize(),
which will calculate the size of array PixelWeight.m_Weights correctly to
prevent potential heap buffer overflow conditions.

BUG=chromium:654183
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2404453003
(cherry picked from commit 05923132ae08d45fbe957219775a48c55ee57aef)

Review URL: https://codereview.chromium.org/2448613002 .

Revert "Re-land "Assert that only 0-numbered objects are Released()""

This reverts commit b69a98cf50537130f88ce3a799117f2ca8353ac5.

Reason for revert: crashes on mac.

BUG=654387
TBR=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2410483002
(cherry picked from commit 5609f39c9d4534733f04a2be631da56948c2e96f)

Review URL: https://codereview.chromium.org/2415823002 .
==========

to

==========
M55: Use m_GlyphIndex as backup for m_ExtGID on Mac

When CGFontGetGlyphWithGlyphName returns 0, it means the glyph name
was not recognized. In this case, try using the glyph index to load the
glyph.

BUG=pdfium:625

Review-Url: https://codereview.chromium.org/2445933002
(cherry picked from commit 4ee6139e8cfecab9e181115894b26131ad6de09a)
==========

[Lei Zhang, 2016-10-28 18:47:59]

lgtm

https://codereview.chromium.org/2460993002/diff/20001/core/fxge/apple/fx_appl...
File core/fxge/apple/fx_apple_platform.cpp (right):

https://codereview.chromium.org/2460993002/diff/20001/core/fxge/apple/fx_appl...
core/fxge/apple/fx_apple_platform.cpp:75: new_matrix.a = -new_matrix.a;
offtopic: still missing "new_matrix.c = -new_matrix.c;"

I wonder if we want to merge that as well. That one seems pretty safe too.

[npm, 2016-10-28 18:48:38]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:48:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:48:49]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[npm, 2016-10-28 18:50:08]

Description was changed from

==========
M55: Use m_GlyphIndex as backup for m_ExtGID on Mac

When CGFontGetGlyphWithGlyphName returns 0, it means the glyph name
was not recognized. In this case, try using the glyph index to load the
glyph.

BUG=pdfium:625

Review-Url: https://codereview.chromium.org/2445933002
(cherry picked from commit 4ee6139e8cfecab9e181115894b26131ad6de09a)
==========

to

==========
M55: Use m_GlyphIndex as backup for m_ExtGID on Mac

When CGFontGetGlyphWithGlyphName returns 0, it means the glyph name
was not recognized. In this case, try using the glyph index to load the
glyph.

BUG=pdfium:625

Review-Url: https://codereview.chromium.org/2445933002
(cherry picked from commit 4ee6139e8cfecab9e181115894b26131ad6de09a)

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/e3183750107b0d54a0229874b1da75e2cae8...
==========

[npm, 2016-10-28 18:50:09]

Committed patchset #1 (id:20001) manually as
e3183750107b0d54a0229874b1da75e2cae8c3ea (presubmit successful).

[npm, 2016-10-28 19:20:55]

https://codereview.chromium.org/2460993002/diff/20001/core/fxge/apple/fx_appl...
File core/fxge/apple/fx_apple_platform.cpp (right):

https://codereview.chromium.org/2460993002/diff/20001/core/fxge/apple/fx_appl...
core/fxge/apple/fx_apple_platform.cpp:75: new_matrix.a = -new_matrix.a;
On 2016/10/28 18:47:58, Lei Zhang wrote:
> offtopic: still missing "new_matrix.c = -new_matrix.c;"
> 
> I wonder if we want to merge that as well. That one seems pretty safe too.

Yea. Should I submit a merge request?

[Lei Zhang, 2016-10-28 19:40:33]

On 2016/10/28 19:20:55, npm wrote:
>
https://codereview.chromium.org/2460993002/diff/20001/core/fxge/apple/fx_appl...
> File core/fxge/apple/fx_apple_platform.cpp (right):
> 
>
https://codereview.chromium.org/2460993002/diff/20001/core/fxge/apple/fx_appl...
> core/fxge/apple/fx_apple_platform.cpp:75: new_matrix.a = -new_matrix.a;
> On 2016/10/28 18:47:58, Lei Zhang wrote:
> > offtopic: still missing "new_matrix.c = -new_matrix.c;"
> > 
> > I wonder if we want to merge that as well. That one seems pretty safe too.
> 
> Yea. Should I submit a merge request?

Sure. Seems safe to merge.