Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2456943002: M55: Convert from int to float values. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2883
Project:
pdfium
Visibility:
Public.

Description

M55: Convert from int to float values. The CPDF_Page::GetDisplayMatrix expects to set float values into the |display_matrix| but all of the input values are currently int. It is possible to overflow the int values, so this CL changes the variables to be int which closer reflects what they're being used for. BUG=chromium:652038 Review-Url: https://codereview.chromium.org/2412983002 (cherry picked from commit 798e18f5e5cfb672c7f3186f6358b84c5ff7785b) Committed: https://pdfium.googlesource.com/pdfium/+/fee1e9ff603527d2ccd45d3e6fd32886228b917a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M core/fpdfapi/page/cpdf_page.cpp View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Lei Zhang
TBR
4 years, 1 month ago (2016-10-27 20:33:27 UTC) #2
Lei Zhang
4 years, 1 month ago (2016-10-27 20:33:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fee1e9ff603527d2ccd45d3e6fd32886228b917a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698