Convert from int to float values.

Convert from int to float values.

The CPDF_Page::GetDisplayMatrix expects to set float values into the
|display_matrix| but all of the input values are currently int. It is possible
to overflow the int values, so this CL changes the variables to be int which
closer reflects what they're being used for.

BUG=chromium:652038
Committed: https://pdfium.googlesource.com/pdfium/+/798e18f5e5cfb672c7f3186f6358b84c5ff7785b

[dsinclair, 2016-10-12 18:50:43]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-10-12 18:50:43]

PTAL.

[Lei Zhang, 2016-10-12 18:59:53]

lgtm

https://codereview.chromium.org/2412983002/diff/1/core/fpdfapi/page/cpdf_page...
File core/fpdfapi/page/cpdf_page.cpp (right):

https://codereview.chromium.org/2412983002/diff/1/core/fpdfapi/page/cpdf_page...
core/fpdfapi/page/cpdf_page.cpp:129: float x0 = 0;
No need to initialize?

[dsinclair, 2016-10-12 19:03:18]

https://codereview.chromium.org/2412983002/diff/1/core/fpdfapi/page/cpdf_page...
File core/fpdfapi/page/cpdf_page.cpp (right):

https://codereview.chromium.org/2412983002/diff/1/core/fpdfapi/page/cpdf_page...
core/fpdfapi/page/cpdf_page.cpp:129: float x0 = 0;
On 2016/10/12 18:59:53, Lei Zhang wrote:
> No need to initialize?

Done.

[dsinclair, 2016-10-12 19:03:26]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-12 19:03:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2412983002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-10-12 19:03:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:08:44]

Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[dsinclair, 2016-10-12 19:09:14]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-12 19:09:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2412983002/#ps40001
(title: "Win fix.")

[commit-bot: I haz the power, 2016-10-12 19:09:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:05:41]

Description was changed from

==========
Convert from int to float values.

The CPDF_Page::GetDisplayMatrix expects to set float values into the
|display_matrix| but all of the input values are currently int. It is possible
to overflow the int values, so this CL changes the variables to be int which
closer reflects what they're being used for.

BUG=chromium:652038
==========

to

==========
Convert from int to float values.

The CPDF_Page::GetDisplayMatrix expects to set float values into the
|display_matrix| but all of the input values are currently int. It is possible
to overflow the int values, so this CL changes the variables to be int which
closer reflects what they're being used for.

BUG=chromium:652038

Committed:
https://pdfium.googlesource.com/pdfium/+/798e18f5e5cfb672c7f3186f6358b84c5ff7...
==========

[commit-bot: I haz the power, 2016-10-12 20:05:42]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/798e18f5e5cfb672c7f3186f6358b84c5ff7...