Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2410483002: Revert "Re-land "Assert that only 0-numbered objects are Released()"" (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Re-land "Assert that only 0-numbered objects are Released()"" This reverts commit b69a98cf50537130f88ce3a799117f2ca8353ac5. Reason for revert: crashes on mac. BUG=654387 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5609f39c9d4534733f04a2be631da56948c2e96f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -47 lines) Patch
M core/fpdfapi/parser/cpdf_array.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_object.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 6 chunks +7 lines, -25 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 4 chunks +23 lines, -14 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, :(
4 years, 2 months ago (2016-10-10 17:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410483002/1
4 years, 2 months ago (2016-10-10 17:19:38 UTC) #6
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-10 17:27:30 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:25:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5609f39c9d4534733f04a2be631da56948c2...

Powered by Google App Engine
This is Rietveld 408576698