Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2445933002: Use glyph index as backup of ExtGID on Mac (Closed)

Created:
4 years, 1 month ago by npm
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use m_GlyphIndex as backup for m_ExtGID on Mac When CGFontGetGlyphWithGlyphName returns 0, it means the glyph name was not recognized. In this case, try using the glyph index to load the glyph. BUG=pdfium:625 Committed: https://pdfium.googlesource.com/pdfium/+/4ee6139e8cfecab9e181115894b26131ad6de09a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M core/fxge/apple/fx_apple_platform.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL
4 years, 1 month ago (2016-10-25 14:55:18 UTC) #7
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-25 18:25:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445933002/1
4 years, 1 month ago (2016-10-25 18:36:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 18:37:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4ee6139e8cfecab9e181115894b26131ad6d...

Powered by Google App Engine
This is Rietveld 408576698