Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2445873002: M55: Fixup formfiller cleanup (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2883
Project:
pdfium
Visibility:
Public.

Description

M55: Fixup formfiller cleanup The CFFL_InteractiveFormFiller must be cleaned up before the environment because the destruction of the formfiller will trigger the destruction of the formfiller widgets. Some of those widgets may require stopping timers, which requires accessing the environment. BUG=chromium:654272, chromium:653459 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2408163003 (cherry picked from commit 709f5a9301e91365ab87610993c497e386504ead) Committed: https://pdfium.googlesource.com/pdfium/+/d586fe81bc2ec6785fa6d34df73fc564d48a2866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Lei Zhang
Committed patchset #1 (id:1) manually as d586fe81bc2ec6785fa6d34df73fc564d48a2866 (presubmit successful).
4 years, 1 month ago (2016-10-24 20:42:21 UTC) #2
Lei Zhang
4 years, 1 month ago (2016-10-24 20:43:35 UTC) #3
Message was sent while issue was closed.
TBR

Powered by Google App Engine
This is Rietveld 408576698