Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2448613002: M55: Strengthen bounds check in CWeightTable::Calc * part II (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2883
Project:
pdfium
Visibility:
Public.

Description

M55: Strengthen bounds check in CWeightTable::Calc * part II This CL implemented a better version of CWeightTable::GetPixelWeightSize(), which will calculate the size of array PixelWeight.m_Weights correctly to prevent potential heap buffer overflow conditions. BUG=chromium:654183 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2404453003 (cherry picked from commit 05923132ae08d45fbe957219775a48c55ee57aef) Committed: https://pdfium.googlesource.com/pdfium/+/ed6485f1aa4ce9de8b5cab86cc844df4f4bd0b52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fxge/dib/fx_dib_engine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (3 generated)
Lei Zhang
4 years, 1 month ago (2016-10-24 20:39:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed6485f1aa4ce9de8b5cab86cc844df4f4bd0b52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698