Prevent popunders with the new auto-dismissing dialogs.

Prevent popunders with the new auto-dismissing dialogs.

BUG=629964
Committed: https://crrev.com/bfbb4f279b04117cf70c6ae1c1baa5686d9baa5f
Cr-Commit-Position: refs/heads/master@{#429986}

[Avi (use Gerrit), 2016-10-28 18:35:54]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:36:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 19:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 19:34:49]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-28 20:28:50]

avi@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-10-31 10:35:33]

lgtm

[jochen (gone - plz use gerrit), 2016-10-31 10:36:07]

how difficult would it be to add a test to
chrome/browser/ui/blocked_contents/popup_blocker_browsertest.cc?

[Avi (use Gerrit), 2016-10-31 16:01:05]

On 2016/10/31 10:36:07, jochen (ooo Nov 1) wrote:
> how difficult would it be to add a test to
> chrome/browser/ui/blocked_contents/popup_blocker_browsertest.cc?

I don't know. It's triggered by a feature flag, so running all of those tests
again with a new commandline would work, though I don't know if that's simple.

[jochen (gone - plz use gerrit), 2016-10-31 20:17:18]

On 2016/10/31 at 16:01:05, avi wrote:
> On 2016/10/31 10:36:07, jochen (ooo Nov 1) wrote:
> > how difficult would it be to add a test to
> > chrome/browser/ui/blocked_contents/popup_blocker_browsertest.cc?
> 
> I don't know. It's triggered by a feature flag, so running all of those tests
again with a new commandline would work, though I don't know if that's simple.

what about a test similar to PopupBlockerBrowserTest.ModalPopUnder that enables
the feature explicitly and instead of dismissing the alert explicitly switches
tabs?

[Avi (use Gerrit), 2016-11-04 16:34:41]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 16:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:18:35]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-04 17:54:10]

Please take a look.

[jochen (gone - plz use gerrit), 2016-11-04 18:26:36]

lgtm

[Avi (use Gerrit), 2016-11-04 19:51:18]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:52:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:57:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-04 20:00:48]

Description was changed from

==========
Prevent popunders with the new auto-dismissing dialogs.

BUG=629964
==========

to

==========
Prevent popunders with the new auto-dismissing dialogs.

BUG=629964

Committed: https://crrev.com/bfbb4f279b04117cf70c6ae1c1baa5686d9baa5f
Cr-Commit-Position: refs/heads/master@{#429986}
==========

[commit-bot: I haz the power, 2016-11-04 20:00:49]

Patchset 2 (id:??) landed as
https://crrev.com/bfbb4f279b04117cf70c6ae1c1baa5686d9baa5f
Cr-Commit-Position: refs/heads/master@{#429986}