Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs. (Closed)
Patch Set: with test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
index dae643be2514cd3533d8953a6bdad7a5db48d331..76c2033be2c93ebad8ef492fd9ba39a2ce27bc7d 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
@@ -7,6 +7,7 @@
#include <memory>
+#include "base/callback_forward.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/browser_list_observer.h"
@@ -37,6 +38,8 @@ class JavaScriptDialogTabHelper
explicit JavaScriptDialogTabHelper(content::WebContents* web_contents);
~JavaScriptDialogTabHelper() override;
+ void SetDialogShownCallbackForTesting(base::Closure callback);
+
// JavaScriptDialogManager:
void RunJavaScriptDialog(content::WebContents* web_contents,
const GURL& origin_url,
@@ -76,6 +79,8 @@ class JavaScriptDialogTabHelper
// user's input but by a call to |CloseDialog|, this class will call it.
content::JavaScriptDialogManager::DialogClosedCallback dialog_callback_;
+ base::Closure dialog_shown_;
+
DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogTabHelper);
};

Powered by Google App Engine
This is Rietveld 408576698