chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc - Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc

Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs. (Closed)

Patch Set: with test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc

index 233df4168d4cbdcfc04962bb613a7916d6a6d28f..ee59a37f3067e5a680eeb7db49f7e499162729ab 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc

@@ -99,7 +99,8 @@ JavaScriptDialogViews::JavaScriptDialogViews(

const base::string16& default_prompt_text,

const content::JavaScriptDialogManager::DialogClosedCallback&

dialog_callback)

- : title_(title),

+ : JavaScriptDialog(parent_web_contents),

+ title_(title),

message_type_(message_type),

message_text_(message_text),

default_prompt_text_(default_prompt_text),