Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Side by Side Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs. (Closed)
Patch Set: with test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h" 5 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h"
6 6
7 #import "base/mac/scoped_nsobject.h" 7 #import "base/mac/scoped_nsobject.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h" 10 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 171
172 JavaScriptDialogCocoa::JavaScriptDialogCocoa( 172 JavaScriptDialogCocoa::JavaScriptDialogCocoa(
173 content::WebContents* parent_web_contents, 173 content::WebContents* parent_web_contents,
174 content::WebContents* alerting_web_contents, 174 content::WebContents* alerting_web_contents,
175 const base::string16& title, 175 const base::string16& title,
176 content::JavaScriptMessageType message_type, 176 content::JavaScriptMessageType message_type,
177 const base::string16& message_text, 177 const base::string16& message_text,
178 const base::string16& default_prompt_text, 178 const base::string16& default_prompt_text,
179 const content::JavaScriptDialogManager::DialogClosedCallback& 179 const content::JavaScriptDialogManager::DialogClosedCallback&
180 dialog_callback) 180 dialog_callback)
181 : impl_(base::MakeUnique<JavaScriptDialogCocoaImpl>(this, 181 : JavaScriptDialog(parent_web_contents),
182 impl_(base::MakeUnique<JavaScriptDialogCocoaImpl>(this,
182 parent_web_contents, 183 parent_web_contents,
183 alerting_web_contents, 184 alerting_web_contents,
184 title, 185 title,
185 message_type, 186 message_type,
186 message_text, 187 message_text,
187 default_prompt_text, 188 default_prompt_text,
188 dialog_callback)), 189 dialog_callback)),
189 weak_factory_(this) {} 190 weak_factory_(this) {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698