Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog.h

Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs. (Closed)
Patch Set: with test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog.h
index 3e10dadbcdacb6be716ef1dac261ab45f1b8d3bf..5deecea2e6626bd398ea04435f48f2eb3fe6a8e6 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog.h
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog.h
@@ -5,9 +5,13 @@
#ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_
#define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_
+#include <memory>
+
#include "base/memory/weak_ptr.h"
#include "content/public/browser/javascript_dialog_manager.h"
+class AppModalDialogHelper;
+
class JavaScriptDialog {
public:
virtual ~JavaScriptDialog();
@@ -27,6 +31,12 @@ class JavaScriptDialog {
// respond to a call that requires it to make no callback or make a customized
// one.
virtual void CloseDialogWithoutCallback() = 0;
+
+ protected:
+ explicit JavaScriptDialog(content::WebContents* parent_web_contents);
+
+ private:
+ std::unique_ptr<AppModalDialogHelper> dialog_helper_;
};
#endif // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_

Powered by Google App Engine
This is Rietveld 408576698