Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog.cc

Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs. (Closed)
Patch Set: with test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
index 256e159c96db72c7704de9778039b6893fa7968b..12ea34a784a96792a936aaf365dc40f3cd7fe15f 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
@@ -4,7 +4,15 @@
#include "chrome/browser/ui/javascript_dialogs/javascript_dialog.h"
+#include "chrome/browser/ui/blocked_content/app_modal_dialog_helper.h"
#include "chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_delegate.h"
+
+JavaScriptDialog::JavaScriptDialog(content::WebContents* parent_web_contents) {
+ dialog_helper_.reset(new AppModalDialogHelper(parent_web_contents));
+ parent_web_contents->GetDelegate()->ActivateContents(parent_web_contents);
+}
JavaScriptDialog::~JavaScriptDialog() = default;

Powered by Google App Engine
This is Rietveld 408576698