Prevent popunders with the new auto-dismissing dialogs.

chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h"
 
 #include "base/bind.h"
+#include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/engagement/site_engagement_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tab_modal_confirm_dialog.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_features.h"
 #include "components/app_modal/javascript_dialog_manager.h"
-#include "content/public/browser/web_contents_delegate.h"
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(JavaScriptDialogTabHelper);
 
 namespace {
 
-const base::Feature kAutoDismissingDialogsFeature{
-    "AutoDismissingDialogs", base::FEATURE_DISABLED_BY_DEFAULT};
-
 bool IsEnabled() {
-  return base::FeatureList::IsEnabled(kAutoDismissingDialogsFeature);
+  return base::FeatureList::IsEnabled(features::kAutoDismissingDialogs);
 }
 
 app_modal::JavaScriptDialogManager* AppModalDialogManager() {
   return app_modal::JavaScriptDialogManager::GetInstance();
 }
 
 bool IsWebContentsForemost(content::WebContents* web_contents) {
   Browser* browser = BrowserList::GetInstance()->GetLastActive();
   DCHECK(browser);
   return browser->tab_strip_model()->GetActiveWebContents() == web_contents;
 }
 
 }  // namespace
 
 JavaScriptDialogTabHelper::JavaScriptDialogTabHelper(
     content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents) {
 }
 
 JavaScriptDialogTabHelper::~JavaScriptDialogTabHelper() {
 }
 
+void JavaScriptDialogTabHelper::SetDialogShownCallbackForTesting(
+    base::Closure callback) {
+  dialog_shown_ = callback;
+}
+
 void JavaScriptDialogTabHelper::RunJavaScriptDialog(
     content::WebContents* alerting_web_contents,
     const GURL& origin_url,
     content::JavaScriptMessageType message_type,
     const base::string16& message_text,
     const base::string16& default_prompt_text,
     const DialogClosedCallback& callback,
     bool* did_suppress_message) {
   SiteEngagementService* site_engagement_service = SiteEngagementService::Get(
       Profile::FromBrowserContext(alerting_web_contents->GetBrowserContext()));
@@ skipping 24 matching lines @@
       // turn off focus stealing for other dialog types.
       *did_suppress_message = true;
       return;
     }
 
     if (dialog_) {
       // There's already a dialog up; clear it out.
       CloseDialog(false, false, base::string16());
     }
 
-    parent_web_contents->GetDelegate()->ActivateContents(parent_web_contents);
-
     base::string16 title =
         AppModalDialogManager()->GetTitle(alerting_web_contents, origin_url);
     dialog_callback_ = callback;
-    BrowserList::AddObserver(this);
     dialog_ = JavaScriptDialog::Create(
         parent_web_contents, alerting_web_contents, title, message_type,
         message_text, default_prompt_text, callback);
 
+    BrowserList::AddObserver(this);
+
     // Message suppression is something that we don't give the user a checkbox
     // for any more. It was useful back in the day when dialogs were app-modal
     // and clicking the checkbox was the only way to escape a loop that the page
     // was doing, but now the user can just close the page.
     *did_suppress_message = false;
+
+    if (!dialog_shown_.is_null()) {
+      dialog_shown_.Run();
+      dialog_shown_.Reset();
+    }
   } else {
     AppModalDialogManager()->RunJavaScriptDialog(
         alerting_web_contents, origin_url, message_type, message_text,
         default_prompt_text, callback, did_suppress_message);
   }
 
   if (did_suppress_message) {
     UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCountUserSuppressed",
                          message_length);
   }
@@ skipping 82 matching lines @@
   DCHECK(dialog_);
 
   dialog_->CloseDialogWithoutCallback();
   if (!suppress_callback)
     dialog_callback_.Run(success, user_input);
 
   dialog_.reset();
   dialog_callback_.Reset();
   BrowserList::RemoveObserver(this);
 }