Get rid of createVisibleSelection() taking two Position

Get rid of createVisibleSelection() taking two Position

This patch gets rid of flat tree version of |createVisibleSelection()| taking
two |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/02a3e9549a9be351eb995a6e69ef949d60674900
Cr-Commit-Position: refs/heads/master@{#427633}

[yosin_UTC9, 2016-10-25 07:59:58]

Description was changed from

==========
2016-10-25T16:58:36

BUG=
==========

to

==========
Get rid of flat tree version of createVisibleSelection() taking two Position

This patch gets rid of flat tree version of |createVisibleSelection()| taking
two |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-25 08:00:03]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 08:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 08:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 08:09:31]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2016-10-25 09:26:48]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-25 09:27:53]

Description was changed from

==========
Get rid of flat tree version of createVisibleSelection() taking two Position

This patch gets rid of flat tree version of |createVisibleSelection()| taking
two |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Get rid of createVisibleSelection() taking two Position

This patch gets rid of flat tree version of |createVisibleSelection()| taking
two |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-25 09:32:59]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-25 09:33:00]

PTAL

Not only core/editing changes but also:
 - core/page/DragController.cpp

This is the last patch for getting rid of createVisibleSelection() overloads.

[commit-bot: I haz the power, 2016-10-25 10:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 10:58:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2016-10-25 13:20:56]

Please fix layout test failure...

[yosin_UTC9, 2016-10-26 02:30:36]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 02:30:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-26 04:18:02]

PTAL

Layout test failure is caused by SVG USE element which modifies DOM tree during
updateStyleAndLayout*(). So, restore updateStyleAndLayout*() in
DOMSelection::setBaseAndExtent()

[commit-bot: I haz the power, 2016-10-26 05:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 05:20:28]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-26 05:49:18]

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:1603:
SelectionInDOMTree::Builder().collapse(start).extend(end).build()));
Do we have non-null start and end here?

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:616:
.setBaseAndExtentDeprecated(Position::beforeNode(table),
We can use |setBaseAndExtent| since Position::beforeNode(table) cannot be null.

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/DragController.cpp:622:
innerFrame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
We can remove it now.

[yosin_UTC9, 2016-10-26 06:25:41]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 06:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 07:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 07:42:22]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-26 07:43:07]

PTAL

Update as suggested.

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:1603:
SelectionInDOMTree::Builder().collapse(start).extend(end).build()));
On 2016/10/26 at 05:49:18, Xiaocheng wrote:
> Do we have non-null start and end here?

I would like to know the case which makes start| or |end| as null.

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:616:
.setBaseAndExtentDeprecated(Position::beforeNode(table),
On 2016/10/26 at 05:49:18, Xiaocheng wrote:
> We can use |setBaseAndExtent| since Position::beforeNode(table) cannot be
null.

Done.

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/2451613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/DragController.cpp:622:
innerFrame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/26 at 05:49:18, Xiaocheng wrote:
> We can remove it now.

Good catch!
Done.

[Xiaocheng, 2016-10-26 08:02:49]

lgtm

[tkent, 2016-10-26 08:09:16]

lgtm

[yosin_UTC9, 2016-10-26 08:13:28]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-26 08:13:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 08:18:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-26 08:20:07]

Description was changed from

==========
Get rid of createVisibleSelection() taking two Position

This patch gets rid of flat tree version of |createVisibleSelection()| taking
two |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Get rid of createVisibleSelection() taking two Position

This patch gets rid of flat tree version of |createVisibleSelection()| taking
two |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/02a3e9549a9be351eb995a6e69ef949d60674900
Cr-Commit-Position: refs/heads/master@{#427633}
==========

[commit-bot: I haz the power, 2016-10-26 08:20:08]

Patchset 4 (id:??) landed as
https://crrev.com/02a3e9549a9be351eb995a6e69ef949d60674900
Cr-Commit-Position: refs/heads/master@{#427633}