third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp - Issue 2451613003: Get rid of createVisibleSelection() taking two Position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)

Patch Set: 2016-10-26T15:09:55 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

index b40897ec7e917cda1e3ea82d94877a50c90223f1..c7792716460e99c1df5e1960c61fa3bcb5800c86 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

@@ -33,8 +33,11 @@ TEST_F(InsertListCommandTest, ShouldCleanlyRemoveSpuriousTextNode) {

Text* emptyText = document().createTextNode("");

document().body()->insertBefore(emptyText, document().body()->firstChild());

updateAllLifecyclePhases();

- document().frame()->selection().setSelection(createVisibleSelection(

- Position(document().body(), 0), Position(document().body(), 2)));

+ document().frame()->selection().setSelection(

+ SelectionInDOMTree::Builder()

+ .collapse(Position(document().body(), 0))

+ .extend(Position(document().body(), 2))

+ .build());

InsertListCommand* command =

InsertListCommand::create(document(), InsertListCommand::OrderedList);