third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp - Issue 2451613003: Get rid of createVisibleSelection() taking two Position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)

Patch Set: 2016-10-26T15:09:55 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

index e132bf87ca80c8ba9b57dca7066a50736b401d1d..6fcdd36c5dbb01a9cc65d41481bdbc18e3f90293 100644

--- a/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

@@ -56,9 +56,11 @@ void CreateLinkCommand::doApply(EditingState* editingState) {

return;

document().updateStyleAndLayoutIgnorePendingStylesheets();

setEndingSelection(createVisibleSelection(

- Position::inParentBeforeNode(*anchorElement),

- Position::inParentAfterNode(*anchorElement), TextAffinity::Downstream,

- endingSelection().isDirectional()));

+ SelectionInDOMTree::Builder()

+ .collapse(Position::inParentBeforeNode(*anchorElement))

+ .extend(Position::inParentAfterNode(*anchorElement))

+ .setIsDirectional(endingSelection().isDirectional())

+ .build()));

}