Get rid of createVisibleSelection() taking two Position

third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleSelection.h"
 
 #include "core/dom/Range.h"
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/SelectionAdjuster.h"
 
@@ skipping 194 matching lines @@
       "id='s5'>55</span><content select=#one></content><span "
       "id='s6'>66</span></a>";
   setBodyContent(bodyContent);
   ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");
 
   Element* body = document().body();
   Element* host = body->querySelector("#host");
   Element* one = body->querySelector("#one");
   Element* six = shadowRoot->querySelector("#s6");
 
-  VisibleSelection selection =
-      createVisibleSelection(Position::firstPositionInNode(one),
-                             Position::lastPositionInNode(shadowRoot));
+  VisibleSelection selection = createVisibleSelection(
+      SelectionInDOMTree::Builder()
+          .collapse(Position::firstPositionInNode(one))
+          .extend(Position::lastPositionInNode(shadowRoot))
+          .build());
   VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelection(
       SelectionInFlatTree::Builder()
           .collapse(PositionInFlatTree::firstPositionInNode(one))
           .extend(PositionInFlatTree::lastPositionInNode(host))
           .build());
 
   EXPECT_EQ(Position(host, PositionAnchorType::BeforeAnchor),
             selection.start());
   EXPECT_EQ(Position(one->firstChild(), 0), selection.end());
   EXPECT_EQ(PositionInFlatTree(one->firstChild(), 0),
@@ skipping 10 matching lines @@
       "id='s5'>55</span><content select=#one></content><span "
       "id='s6'>66</span></a>";
   setBodyContent(bodyContent);
   ShadowRoot* shadowRoot = setShadowContent(shadowContent, "host");
 
   Element* body = document().body();
   Element* one = body->querySelector("#one");
   Element* two = body->querySelector("#two");
   Element* five = shadowRoot->querySelector("#s5");
 
-  VisibleSelection selection = createVisibleSelection(
-      Position::firstPositionInNode(one), Position::lastPositionInNode(two));
+  VisibleSelection selection =
+      createVisibleSelection(SelectionInDOMTree::Builder()
+                                 .collapse(Position::firstPositionInNode(one))
+                                 .extend(Position::lastPositionInNode(two))
+                                 .build());
   VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelection(
       SelectionInFlatTree::Builder()
           .collapse(PositionInFlatTree::firstPositionInNode(one))
           .extend(PositionInFlatTree::lastPositionInNode(two))
           .build());
 
   EXPECT_EQ(Position(one->firstChild(), 0), selection.start());
   EXPECT_EQ(Position(two->firstChild(), 2), selection.end());
   EXPECT_EQ(PositionInFlatTree(five->firstChild(), 0),
             selectionInFlatTree.start());
@@ skipping 21 matching lines @@
   //    <b id="two">22</b>
   //    <span id="s5"><span id="s7">77>55</span id="s8">88</span>
   //    <b id="one">11</b>
   //    <span id="s6">66</span>
   //  </p>
   Element* body = document().body();
   Element* host = body->querySelector("#host");
   Element* one = body->querySelector("#one");
   Element* eight = shadowRoot2->querySelector("#s8");
 
-  VisibleSelection selection =
-      createVisibleSelection(Position::firstPositionInNode(one),
-                             Position::lastPositionInNode(shadowRoot2));
+  VisibleSelection selection = createVisibleSelection(
+      SelectionInDOMTree::Builder()
+          .collapse(Position::firstPositionInNode(one))
+          .extend(Position::lastPositionInNode(shadowRoot2))
+          .build());
   VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelection(
       SelectionInFlatTree::Builder()
           .collapse(PositionInFlatTree::firstPositionInNode(one))
           .extend(PositionInFlatTree::afterNode(eight))
           .build());
 
   EXPECT_EQ(Position(host, PositionAnchorType::BeforeAnchor),
             selection.start());
   EXPECT_EQ(Position(one->firstChild(), 0), selection.end());
   EXPECT_EQ(PositionInFlatTree(eight->firstChild(), 2),
@@ skipping 141 matching lines @@
   selection.updateIfNeeded();
   EXPECT_EQ(Position(sample->firstChild(), 0), selection.start());
 
   VisibleSelectionInFlatTree selectionInFlatTree;
   SelectionAdjuster::adjustSelectionInFlatTree(&selectionInFlatTree, selection);
   EXPECT_EQ(PositionInFlatTree(sample->firstChild(), 0),
             selectionInFlatTree.start());
 }
 
 }  // namespace blink