Get rid of createVisibleSelection() taking two Position

third_party/WebKit/Source/core/page/DragController.cpp

 /*
  * Copyright (C) 2007, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 601 matching lines @@
               ? InsertMode::Smart
               : InsertMode::Simple;
 
       if (!innerFrame->editor().deleteSelectionAfterDraggingWithEvents(
               innerFrame->editor().findEventTargetFromSelection(), deleteMode,
               dragCaret.base()))
         return false;
 
       // TODO(xiaochengh): Use of updateStyleAndLayoutIgnorePendingStylesheets
       // needs to be audited.  See http://crbug.com/590369 for more details.
       innerFrame->document()->updateStyleAndLayoutIgnorePendingStylesheets();

[Xiaocheng, 2016/10/26 05:49:18]

We can remove it now.

[yosin_UTC9, 2016/10/26 07:43:07]

Good catch!
Done.

 
       innerFrame->selection().setSelection(
-          createVisibleSelection(range->startPosition(), range->endPosition()));
+          SelectionInDOMTree::Builder()
+              .setBaseAndExtent(EphemeralRange(range))
+              .build());
       if (innerFrame->selection().isAvailable()) {
         DCHECK(m_documentUnderMouse);
         if (!innerFrame->editor().replaceSelectionAfterDraggingWithEvents(
                 element, dragData, fragment, range, insertMode, dragSourceType))
           return false;
       }
     } else {
       if (setSelectionToDragCaret(innerFrame, dragCaret, range, point)) {
         DCHECK(m_documentUnderMouse);
         if (!innerFrame->editor().replaceSelectionAfterDraggingWithEvents(
@@ skipping 580 matching lines @@
 }
 
 DEFINE_TRACE(DragController) {
   visitor->trace(m_page);
   visitor->trace(m_documentUnderMouse);
   visitor->trace(m_dragInitiator);
   visitor->trace(m_fileInputElementUnderMouse);
 }
 
 }  // namespace blink