Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)
Patch Set: 2016-10-26T15:09:55 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp b/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
index b15506626927185b952a4264d19438562cca42ce..1e60262b207090e183d2966a1203d84308dc6464 100644
--- a/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp
@@ -18,7 +18,10 @@ TEST_F(SelectionAdjusterTest, adjustSelectionInFlatTree) {
Node* const foo = sample->firstChild();
// Select "foo"
VisibleSelection selection =
- createVisibleSelection(Position(foo, 0), Position(foo, 3));
+ createVisibleSelection(SelectionInDOMTree::Builder()
+ .collapse(Position(foo, 0))
+ .extend(Position(foo, 3))
+ .build());
SelectionAdjuster::adjustSelectionInFlatTree(&selectionInFlatTree, selection);
EXPECT_EQ(PositionInFlatTree(foo, 0), selectionInFlatTree.start());
EXPECT_EQ(PositionInFlatTree(foo, 3), selectionInFlatTree.end());

Powered by Google App Engine
This is Rietveld 408576698