Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)
Patch Set: 2016-10-26T15:09:55 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index d0c450644614ad7b0ff9f1d688f017f30e8d770e..04527dafb5f0fbe0f1a08f0301217b13ff6895e5 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -72,21 +72,6 @@ VisibleSelection createVisibleSelection(const SelectionInDOMTree& selection) {
return VisibleSelection::create(selection);
}
-VisibleSelection createVisibleSelection(const Position& base,
- const Position& extent,
- TextAffinity affinity,
- bool isDirectional) {
- DCHECK(!needsLayoutTreeUpdate(base));
- DCHECK(!needsLayoutTreeUpdate(extent));
- // TODO(yosin): We should use |Builder::setBaseAndExtent()| once we get rid
- // of callers passing |base.istNull()| but |extent.isNotNull()|.
- SelectionInDOMTree::Builder builder;
- builder.setBaseAndExtentDeprecated(base, extent)
- .setAffinity(affinity)
- .setIsDirectional(isDirectional);
- return createVisibleSelection(builder.build());
-}
-
VisibleSelectionInFlatTree createVisibleSelection(
const SelectionInFlatTree& selection) {
return VisibleSelectionInFlatTree::create(selection);

Powered by Google App Engine
This is Rietveld 408576698