Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch changes call sites of |EditCommand::setEndingSelection()| passing
|VisibleSelection| to |SeelctionInDOMTree| to reduce usage of |VisibleSelection|
and reduce update layout tree and as a preparation of introducing
|SelecitonForUndoStep|, http://crrev.com/2457523004, for farther reduce of
update layout calls.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/e3d2a5b25ef09f4c8458db05080e604efae9c1aa
Cr-Commit-Position: refs/heads/master@{#428305}

[yosin_UTC9, 2016-10-26 10:06:19]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 10:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 11:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 11:17:17]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-27 04:16:52]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 04:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 04:35:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-10-27 05:56:55]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 05:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 07:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:27:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-10-27 09:28:04]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 09:28:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 10:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 10:48:50]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-28 01:43:30]

Description was changed from

==========
2016-10-26T19:03:17

BUG=
==========

to

==========
Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch changes call sites of |EditCommand::setEndingSelection()| passing
|VisibleSelection| to |SeelctionInDOMTree| to reduce usage of |VisibleSelection|
and reduce update layout tree and as a preparation of introducing
|SelecitonForUndoStep|, http://crrev.com/2457523004, for farther reduce of
update layout calls.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-28 01:43:44]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-28 01:43:45]

PTAL

[Xiaocheng, 2016-10-28 02:25:26]

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
(right):

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp:88:
const VisibleSelection newSelection =
We can remove |newSelection|, as |builder| builds a non-null selection here.

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
(right):

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp:145:
document().updateStyleAndLayoutIgnorePendingStylesheets();
This can also be removed.

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
(right):

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp:136:
document().updateStyleAndLayoutIgnorePendingStylesheets();
This one can also be removed.

[yosin_UTC9, 2016-10-28 04:24:55]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 04:25:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 05:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 05:36:59]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2016-10-28 05:45:00]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 05:45:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-28 06:06:49]

PTAL

Updated to follow review comments.

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
(right):

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp:145:
document().updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/28 at 02:25:26, Xiaocheng wrote:
> This can also be removed.

Done.

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
(right):

https://codereview.chromium.org/2450213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp:136:
document().updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/28 at 02:25:26, Xiaocheng wrote:
> This one can also be removed.

Done.

[Xiaocheng, 2016-10-28 06:55:17]

lgtm

[yosin_UTC9, 2016-10-28 07:14:57]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-10-28 07:14:59]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-28 07:15:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 07:19:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-28 07:22:21]

Description was changed from

==========
Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch changes call sites of |EditCommand::setEndingSelection()| passing
|VisibleSelection| to |SeelctionInDOMTree| to reduce usage of |VisibleSelection|
and reduce update layout tree and as a preparation of introducing
|SelecitonForUndoStep|, http://crrev.com/2457523004, for farther reduce of
update layout calls.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

This patch changes call sites of |EditCommand::setEndingSelection()| passing
|VisibleSelection| to |SeelctionInDOMTree| to reduce usage of |VisibleSelection|
and reduce update layout tree and as a preparation of introducing
|SelecitonForUndoStep|, http://crrev.com/2457523004, for farther reduce of
update layout calls.

BUG=657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/e3d2a5b25ef09f4c8458db05080e604efae9c1aa
Cr-Commit-Position: refs/heads/master@{#428305}
==========

[commit-bot: I haz the power, 2016-10-28 07:22:22]

Patchset 6 (id:??) landed as
https://crrev.com/e3d2a5b25ef09f4c8458db05080e604efae9c1aa
Cr-Commit-Position: refs/heads/master@{#428305}