Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 2450213002: Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree (Closed)
Patch Set: 2016-10-28T14:44:14 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.h b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
index 57b2d92708a26b94432ae3d21db81445a70c4306..34939bc1a28b5aa947b02f3d3c7cb689dd5e0aba 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
@@ -69,9 +69,9 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
CompositeEditCommand* parent() const { return m_parent; }
void setStartingSelection(const VisibleSelection&);
void setEndingSelection(const SelectionInDOMTree&);
- // TODO(yosin): We should get rid of overloads of |setEndingSelection()|
- // except for taking |SelectionInDOMTree|.
- void setEndingSelection(const VisibleSelection&);
+ // TODO(yosin): |setEndingVisibleSelection()| will take |SelectionInUndoStep|
+ // You should not use this function other than copying existing selection.
+ void setEndingVisibleSelection(const VisibleSelection&);
// TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
// |VisiblePosition::characterAfter()| and

Powered by Google App Engine
This is Rietveld 408576698