third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp - Issue 2450213002: Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

Issue 2450213002: Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree (Closed)

Patch Set: 2016-10-28T14:44:14 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

index 6fcdd36c5dbb01a9cc65d41481bdbc18e3f90293..566650e1d35c4e1e433d66649f1216bf325e8989 100644

--- a/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

@@ -54,13 +54,12 @@ void CreateLinkCommand::doApply(EditingState* editingState) {

appendNode(textNode, anchorElement, editingState);

if (editingState->isAborted())

return;

- document().updateStyleAndLayoutIgnorePendingStylesheets();

- setEndingSelection(createVisibleSelection(

+ setEndingSelection(

SelectionInDOMTree::Builder()

.collapse(Position::inParentBeforeNode(*anchorElement))

.extend(Position::inParentAfterNode(*anchorElement))

.setIsDirectional(endingSelection().isDirectional())

- .build()));

+ .build());

}