Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

 /*
  * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 108 matching lines @@
         appendNode(extraNode, nodeToInsert->parentNode(), editingState);
       } else {
         extraNode = nodeToInsert->cloneNode(false);
         insertNodeAfter(extraNode, nodeToInsert, editingState);
       }
       if (editingState->isAborted())
         return;
       nodeToInsert = extraNode;
     }
 
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::beforeNode(nodeToInsert))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::beforeNode(nodeToInsert))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
   } else if (pos.computeEditingOffset() <= caretMinOffset(pos.anchorNode())) {
     insertNodeAt(nodeToInsert, pos, editingState);
     if (editingState->isAborted())
       return;
     document().updateStyleAndLayoutIgnorePendingStylesheets();
 
     // Insert an extra br or '\n' if the just inserted one collapsed.
     if (!isStartOfParagraph(VisiblePosition::beforeNode(nodeToInsert))) {
       insertNodeBefore(nodeToInsert->cloneNode(false), nodeToInsert,
                        editingState);
       if (editingState->isAborted())
         return;
       document().updateStyleAndLayoutIgnorePendingStylesheets();

[Xiaocheng, 2016/10/28 02:25:26]

This can also be removed.

[yosin_UTC9, 2016/10/28 06:06:49]

Done.

     }
 
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::inParentAfterNode(*nodeToInsert))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::inParentAfterNode(*nodeToInsert))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
     // If we're inserting after all of the rendered text in a text node, or into
     // a non-text node, a simple insertion is sufficient.
   } else if (!pos.anchorNode()->isTextNode() ||
              pos.computeOffsetInContainerNode() >=
                  caretMaxOffset(pos.anchorNode())) {
     insertNodeAt(nodeToInsert, pos, editingState);
     if (editingState->isAborted())
       return;
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::inParentAfterNode(*nodeToInsert))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::inParentAfterNode(*nodeToInsert))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
   } else if (pos.anchorNode()->isTextNode()) {
     // Split a text node
     Text* textNode = toText(pos.anchorNode());
     splitTextNode(textNode, pos.computeOffsetInContainerNode());
     insertNodeBefore(nodeToInsert, textNode, editingState);
     if (editingState->isAborted())
       return;
     Position endingPosition = Position::firstPositionInNode(textNode);
 
     // Handle whitespace that occurs after the split
@@ skipping 12 matching lines @@
         insertTextIntoNode(textNode, 0, nonBreakingSpaceString());
       } else {
         Text* nbspNode = document().createTextNode(nonBreakingSpaceString());
         insertNodeAt(nbspNode, positionBeforeTextNode, editingState);
         if (editingState->isAborted())
           return;
         endingPosition = Position::firstPositionInNode(nbspNode);
       }
     }
 
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(endingPosition)
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(endingPosition)
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
   }
 
   // Handle the case where there is a typing style.
 
   EditingStyle* typingStyle = document().frame()->selection().typingStyle();
 
   if (typingStyle && !typingStyle->isEmpty()) {
     // Apply the typing style to the inserted line break, so that if the
     // selection leaves and then comes back, new input will have the right
     // style.
@@ skipping 14 matching lines @@
     // block.
     setEndingSelection(SelectionInDOMTree::Builder()
                            .collapse(endingSelection().end())
                            .build());
   }
 
   rebalanceWhitespace();
 }
 
 }  // namespace blink