third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2450213002: Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2450213002: Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree (Closed)

Patch Set: 2016-10-28T14:44:14 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index 12a85840a055e8a51cfab1c133d3336418f83eb6..c1d90ed281fb025c5d61862dcf478e2a71c678dc 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -189,13 +189,11 @@ void ApplyStyleCommand::updateStartEnd(const Position& newStart,

if (!m_useEndingSelection && (newStart != m_start || newEnd != m_end))

m_useEndingSelection = true;

- document().updateStyleAndLayoutIgnorePendingStylesheets();

- setEndingSelection(createVisibleSelection(

- SelectionInDOMTree::Builder()

- .collapse(newStart)

- .extend(newEnd)

- .setIsDirectional(endingSelection().isDirectional())

- .build()));

+ setEndingSelection(SelectionInDOMTree::Builder()

+ .collapse(newStart)

+ .extend(newEnd)

+ .setIsDirectional(endingSelection().isDirectional())

+ .build());

m_start = newStart;

m_end = newEnd;

}