Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 103 matching lines @@
       isLastVisiblePositionInNode(visiblePos, topBlockquote);
 
   // If the position is at the beginning of the top quoted content, we don't
   // need to break the quote. Instead, insert the break before the blockquote,
   // unless the position is as the end of the the quoted content.
   if (isFirstVisiblePositionInNode(visiblePos, topBlockquote) &&
       !isLastVisPosInNode) {
     insertNodeBefore(breakElement, topBlockquote, editingState);
     if (editingState->isAborted())
       return;
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::beforeNode(breakElement))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::beforeNode(breakElement))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
     rebalanceWhitespace();
     return;
   }
 
   // Insert a break after the top blockquote.
   insertNodeAfter(breakElement, topBlockquote, editingState);
   if (editingState->isAborted())
     return;
 
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
   // If we're inserting the break at the end of the quoted content, we don't
   // need to break the quote.
   if (isLastVisPosInNode) {
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::beforeNode(breakElement))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::beforeNode(breakElement))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
     rebalanceWhitespace();
     return;
   }
 
   // Don't move a line break just after the caret.  Doing so would create an
   // extra, empty paragraph in the new blockquote.
   if (lineBreakExistsAtVisiblePosition(visiblePos)) {
     pos = nextPositionOf(pos, PositionMoveType::GraphemeCluster);
   }
 
@@ skipping 20 matching lines @@
     }
   } else if (pos.computeEditingOffset() > 0) {
     Node* childAtOffset =
         NodeTraversal::childAt(*startNode, pos.computeEditingOffset());
     startNode = childAtOffset ? childAtOffset : NodeTraversal::next(*startNode);
     DCHECK(startNode);
   }
 
   // If there's nothing inside topBlockquote to move, we're finished.
   if (!startNode->isDescendantOf(topBlockquote)) {
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(firstPositionInOrBeforeNode(startNode))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(firstPositionInOrBeforeNode(startNode))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
     return;
   }
 
   // Build up list of ancestors in between the start node and the top
   // blockquote.
   HeapVector<Member<Element>> ancestors;
   for (Element* node = startNode->parentElement();
        node && node != topBlockquote; node = node->parentElement())
     ancestors.append(node);
 
@@ skipping 59 matching lines @@
       if (editingState->isAborted())
         return;
     }
   }
 
   // Make sure the cloned block quote renders.
   addBlockPlaceholderIfNeeded(clonedBlockquote, editingState);
   if (editingState->isAborted())
     return;
 
-  document().updateStyleAndLayoutIgnorePendingStylesheets();
-
   // Put the selection right before the break.
-  setEndingSelection(createVisibleSelection(
-      SelectionInDOMTree::Builder()
-          .collapse(Position::beforeNode(breakElement))
-          .setIsDirectional(endingSelection().isDirectional())
-          .build()));
+  setEndingSelection(SelectionInDOMTree::Builder()
+                         .collapse(Position::beforeNode(breakElement))
+                         .setIsDirectional(endingSelection().isDirectional())
+                         .build());
   rebalanceWhitespace();
 }
 
 }  // namespace blink